Changeset 95959 in webkit


Ignore:
Timestamp:
Sep 26, 2011, 10:13:09 AM (14 years ago)
Author:
inferno@chromium.org
Message:

Delete retired custom font data only on document
destruction, and not on recalc style.
​https://bugs.webkit.org/show_bug.cgi?id=68805

Reviewed by Dave Hyatt.

Source/WebCore:

Test: fast/text/custom-font-data-crash.html

  • dom/Document.cpp:

(WebCore::Document::recalcStyle):

LayoutTests:

  • fast/text/custom-font-data-crash-expected.txt: Added.
  • fast/text/custom-font-data-crash.html: Added.
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r95957 r95959  
     12011-09-26  Abhishek Arya  <inferno@chromium.org>
     2
     3        Delete retired custom font data only on document
     4        destruction, and not on recalc style.
     5        https://bugs.webkit.org/show_bug.cgi?id=68805
     6
     7        Reviewed by Dave Hyatt.
     8
     9        * fast/text/custom-font-data-crash-expected.txt: Added.
     10        * fast/text/custom-font-data-crash.html: Added.
     11
    1122011-09-23  Adrienne Walker  <enne@google.com>
    213

  • trunk/Source/WebCore/ChangeLog

    r95957 r95959  
     12011-09-26  Abhishek Arya  <inferno@chromium.org>
     2
     3        Delete retired custom font data only on document
     4        destruction, and not on recalc style.
     5        https://bugs.webkit.org/show_bug.cgi?id=68805
     6
     7        Reviewed by Dave Hyatt.
     8
     9        Test: fast/text/custom-font-data-crash.html
     10
     11        * dom/Document.cpp:
     12        (WebCore::Document::recalcStyle):
     13
    1142011-09-23  Adrienne Walker  <enne@google.com>
    215

  • trunk/Source/WebCore/dom/Document.cpp

    r95790 r95959  
    15651565    }
    15661566
     1567    // FIXME: Disabling the deletion of retired custom font data until
     1568    // we fix all the stale style bugs (68804, 68624, etc). These bugs
     1569    // indicate problems where some styles were not updated in recalcStyle,
     1570    // thereby retaining stale copy of font data. To prevent that, we
     1571    // disable this code for now and only delete retired custom font data
     1572    // in Document destructor.
    15671573    // Now that all RenderStyles that pointed to retired fonts have been updated, the fonts can safely be deleted.
    1568     deleteRetiredCustomFonts();
     1574    // deleteRetiredCustomFonts();
    15691575
    15701576#if USE(ACCELERATED_COMPOSITING)
Note: See TracChangeset for help on using the changeset viewer.