Changeset 97010 in webkit

Timestamp:

Oct 8, 2011, 8:37:23 AM (14 years ago)

Author:

commit-queue@webkit.org

Message:

[Qt] [WK2] Wrong handling of visibility in QTouchWebPage
​https://bugs.webkit.org/show_bug.cgi?id=69670

Patch by Viatcheslav Ostapenko <​ostapenko.viatcheslav@nokia.com> on 2011-10-08
Reviewed by Andreas Kling.

Replace QTouchWebPage visibility handling by Show/Hide events with use of
QSGItem::visibleChanged signal.

• UIProcess/API/qt/qtouchwebpage.cpp:

(QTouchWebPage::QTouchWebPage):
(QTouchWebPage::event):
(QTouchWebPage::onVisibleChanged):

• UIProcess/API/qt/qtouchwebpage.h:

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/API/qt/qtouchwebpage.cpp (modified) (3 diffs)
• UIProcess/API/qt/qtouchwebpage.h (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2011-10-08  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
+
+        [Qt] [WK2] Wrong handling of visibility in QTouchWebPage
+        https://bugs.webkit.org/show_bug.cgi?id=69670
+
+        Reviewed by Andreas Kling.
+
+        Replace QTouchWebPage visibility handling by Show/Hide events with use of 
+        QSGItem::visibleChanged signal.
+
+        * UIProcess/API/qt/qtouchwebpage.cpp:
+        (QTouchWebPage::QTouchWebPage):
+        (QTouchWebPage::event):
+        (QTouchWebPage::onVisibleChanged):
+        * UIProcess/API/qt/qtouchwebpage.h:
+
 2011-10-08  Sheriff Bot  <webkit.review.bot@gmail.com>
 

trunk/Source/WebKit2/UIProcess/API/qt/qtouchwebpage.cpp

@@ -39 +39 @@
     // is always where rendering starts.
     setTransformOrigin(TopLeft);
+    connect(this, SIGNAL(visibleChanged()), SLOT(onVisibleChanged()));
 }
 
@@ -92 +93 @@
 bool QTouchWebPage::event(QEvent* ev)
 {
-    switch (ev->type()) {
-    case QEvent::Show:
-        d->page->setPageIsVisible(true);
-        break;
-    case QEvent::Hide:
-        d->page->setPageIsVisible(false);
-        break;
-    default:
-        break;
-    }
-
     if (d->page->handleEvent(ev))
         return true;
@@ -167 +157 @@
 }
 
+void QTouchWebPage::onVisibleChanged()
+{
+    d->page->setPageIsVisible(isVisible());
+}
+
 #include "moc_qtouchwebpage.cpp"

trunk/Source/WebKit2/UIProcess/API/qt/qtouchwebpage.h

@@ -73 +73 @@
     void loadProgressChanged(int progress);
 
+protected Q_SLOTS:
+    void onVisibleChanged();
+
 protected:
     virtual void keyPressEvent(QKeyEvent*);