Changeset 99226 in webkit

Timestamp:

Nov 3, 2011, 12:15:42 PM (14 years ago)

Author:

commit-queue@webkit.org

Message:

[EFL] DRT: Allow choosing which backing store to use.
​https://bugs.webkit.org/show_bug.cgi?id=70532

Patch by Raphael Kubo da Costa <​kubo@profusion.mobi> on 2011-11-03
Reviewed by Antonio Gomes.

This change makes it possible to change the backing store used by DRT
from Tiled Backing Store (TBS) to Single Backing Store (SBS) by
setting the environment variable DRT_USE_SINGLE_BACKING_STORE to 1.

• DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::createView):

• DumpRenderTree/efl/DumpRenderTreeView.cpp:

(shouldUseSingleBackingStore):
(chooseAndInitializeAppropriateSmartClass):
(drtViewAdd):

• DumpRenderTree/efl/DumpRenderTreeView.h:

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• DumpRenderTree/efl/DumpRenderTreeChrome.cpp (modified) (1 diff)
• DumpRenderTree/efl/DumpRenderTreeView.cpp (modified) (2 diffs)
• DumpRenderTree/efl/DumpRenderTreeView.h (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2011-11-03  Raphael Kubo da Costa  <kubo@profusion.mobi>
+
+        [EFL] DRT: Allow choosing which backing store to use.
+        https://bugs.webkit.org/show_bug.cgi?id=70532
+
+        Reviewed by Antonio Gomes.
+
+        This change makes it possible to change the backing store used by DRT
+        from Tiled Backing Store (TBS) to Single Backing Store (SBS) by
+        setting the environment variable DRT_USE_SINGLE_BACKING_STORE to 1.
+
+        * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
+        (DumpRenderTreeChrome::createView):
+        * DumpRenderTree/efl/DumpRenderTreeView.cpp:
+        (shouldUseSingleBackingStore):
+        (chooseAndInitializeAppropriateSmartClass):
+        (drtViewAdd):
+        * DumpRenderTree/efl/DumpRenderTreeView.h:
+
 2011-11-02  Erik Arvidsson  <arv@chromium.org>
 

trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp

@@ -81 +81 @@
 Evas_Object* DumpRenderTreeChrome::createView() const
 {
-    Evas_Object* view = drtViewTiledAdd(m_evas);
+    Evas_Object* view = drtViewAdd(m_evas);
     if (!view)
         return 0;

trunk/Tools/DumpRenderTree/efl/DumpRenderTreeView.cpp

@@ -35 +35 @@
 #include <Evas.h>
 #include <cstdio>
+#include <cstdlib>
 
 using namespace std;
@@ -81 +82 @@
 }
 
-Evas_Object* drtViewTiledAdd(Evas* evas)
+static bool shouldUseSingleBackingStore()
 {
-    static Ewk_View_Smart_Class api = EWK_VIEW_SMART_CLASS_INIT_NAME_VERSION("DRT_View_Tiled");
+    const char* useSingleBackingStore = getenv("DRT_USE_SINGLE_BACKING_STORE");
+    return useSingleBackingStore && *useSingleBackingStore == '1';
+}
 
-    if (!ewk_view_tiled_smart_set(&api))
+static bool chooseAndInitializeAppropriateSmartClass(Ewk_View_Smart_Class* api)
+{
+    return shouldUseSingleBackingStore() ? ewk_view_single_smart_set(api) : ewk_view_tiled_smart_set(api);
+}
+
+Evas_Object* drtViewAdd(Evas* evas)
+{
+    static Ewk_View_Smart_Class api = EWK_VIEW_SMART_CLASS_INIT_NAME_VERSION("DRT_View");
+
+    if (!chooseAndInitializeAppropriateSmartClass(&api))
         return 0;
 

trunk/Tools/DumpRenderTree/efl/DumpRenderTreeView.h

@@ -28 +28 @@
 #include <Evas.h>
 
-Evas_Object* drtViewTiledAdd(Evas*);
+Evas_Object* drtViewAdd(Evas*);
 
 #endif // DumpRenderTreeView_h