Changeset 99243 in webkit

Timestamp:

Nov 3, 2011, 4:17:44 PM (14 years ago)

Author:

andersca@apple.com

Message:

Move plug-in size and backing store checks to PluginProxy::updateBackingStore
​https://bugs.webkit.org/show_bug.cgi?id=71508

Reviewed by Darin Adler.

• WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::geometryDidChange):
Remove code to send back an empty backing store if the plug-in size is empty
or doesn't need a backing store. This check is now done...

(WebKit::PluginProxy::updateBackingStore):
...here.

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/Plugins/PluginProxy.cpp (modified) (2 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2011-11-03  Anders Carlsson  <andersca@apple.com>
+
+        Move plug-in size and backing store checks to PluginProxy::updateBackingStore
+        https://bugs.webkit.org/show_bug.cgi?id=71508
+
+        Reviewed by Darin Adler.
+
+        * WebProcess/Plugins/PluginProxy.cpp:
+        (WebKit::PluginProxy::geometryDidChange):
+        Remove code to send back an empty backing store if the plug-in size is empty
+        or doesn't need a backing store. This check is now done...
+
+        (WebKit::PluginProxy::updateBackingStore):
+        ...here.
+
 2011-11-03  Anders Carlsson  <andersca@apple.com>
 

trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp

@@ -176 +176 @@
     ASSERT(m_isStarted);
 
-    if (m_pluginSize.isEmpty() || !needsBackingStore()) {
-        ShareableBitmap::Handle pluginBackingStoreHandle;
-        m_connection->connection()->send(Messages::PluginControllerProxy::GeometryDidChange(m_pluginSize, m_clipRect, m_pluginToRootViewTransform, contentsScaleFactor(), pluginBackingStoreHandle), m_pluginInstanceID, CoreIPC::DispatchMessageEvenWhenWaitingForSyncReply);
-        return;
-    }
-
     ShareableBitmap::Handle pluginBackingStoreHandle;
 
@@ -443 +437 @@
 bool PluginProxy::updateBackingStore()
 {
+    if (m_pluginSize.isEmpty() || !needsBackingStore())
+        return false;
+
     IntSize backingStoreSize = m_pluginSize;
     backingStoreSize.scale(contentsScaleFactor());