Changeset 99492 in webkit

Timestamp:

Nov 7, 2011, 3:43:21 PM (14 years ago)

Author:

aboxhall@chromium.org

Message:

Remove unnecessary use of function pointer in FrameSelection::modify()
​https://bugs.webkit.org/show_bug.cgi?id=71646

Reviewed by Ryosuke Niwa.

• editing/FrameSelection.cpp:

(WebCore::FrameSelection::modify):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• editing/FrameSelection.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-11-07  Alice Boxhall  <aboxhall@chromium.org>
+
+        Remove unnecessary use of function pointer in FrameSelection::modify()
+        https://bugs.webkit.org/show_bug.cgi?id=71646
+
+        Reviewed by Ryosuke Niwa.
+
+        * editing/FrameSelection.cpp:
+        (WebCore::FrameSelection::modify):
+
 2011-11-07  Andreas Kling  <kling@webkit.org>
 

trunk/Source/WebCore/editing/FrameSelection.cpp

@@ -1025 +1025 @@
     VisiblePosition next;
     for (VisiblePosition p = pos; ; p = next) {
-        next = (direction == DirectionUp ? previousLinePosition : nextLinePosition)(p, xPos);
+        if (direction == DirectionUp)
+            next = previousLinePosition(p, xPos);
+        else
+            next = nextLinePosition(p, xPos);
+
         if (next.isNull() || next == p)
             break;