Changeset 99557 in webkit

Timestamp:

Nov 8, 2011, 5:34:38 AM (14 years ago)

Author:

apavlov@chromium.org

Message:

Web Inspector: Do not hide SuggestBox if typed-in string in the middle of input equals one of suggestions
​https://bugs.webkit.org/show_bug.cgi?id=71797

Reviewed by Yury Semikhatsky.

• inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt.prototype.onKeyDown):
(WebInspector.TextPrompt.prototype.complete):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/TextPrompt.js (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-11-08  Alexander Pavlov  <apavlov@chromium.org>
+
+        Web Inspector: Do not hide SuggestBox if typed-in string in the middle of input equals one of suggestions
+        https://bugs.webkit.org/show_bug.cgi?id=71797
+
+        Reviewed by Yury Semikhatsky.
+
+        * inspector/front-end/TextPrompt.js:
+        (WebInspector.TextPrompt.prototype.onKeyDown):
+        (WebInspector.TextPrompt.prototype.complete):
+
 2011-11-08  Andreas Kling  <kling@webkit.org>
 

trunk/Source/WebCore/inspector/front-end/TextPrompt.js

@@ -229 +229 @@
         case "Right":
         case "End":
-            if (this.isSuggestBoxVisible())
+            if (this.isSuggestBoxVisible() && this.isCaretAtEndOfPrompt())
                 handled = this._suggestBox.tabKeyPressed(event);
             else {
@@ -360 +360 @@
         if (!auto && !isEmptyInput && !selectionRange.commonAncestorContainer.isDescendant(this._element))
             shouldExit = true;
-        if (auto && !this.isCaretAtEndOfPrompt() && !force)
+        if (auto && !this.isCaretAtEndOfPrompt() && !this._suggestBox && !force)
             shouldExit = true;
         if (shouldExit) {