Changeset 99714 in webkit

Timestamp:

Nov 9, 2011, 7:30:38 AM (14 years ago)

Author:

pfeldman@chromium.org

Message:

Chromium: Add plumbing to enable dragging dev tools via the empty space on the toolbar.
​https://bugs.webkit.org/show_bug.cgi?id=71842

These are the only WebKit-side changes needed. The rest will be done on the Chromium side.

Chromium bug: ​http://crbug.com/44350

Patch by Alexei Svitkine <​asvitkine@chromium.org> on 2011-11-09
Reviewed by Pavel Feldman.

• public/WebDevToolsFrontendClient.h:

(WebKit::WebDevToolsFrontendClient::moveWindowBy):

• src/InspectorFrontendClientImpl.cpp:

(WebKit::InspectorFrontendClientImpl::moveWindowBy):

Location:

trunk/Source/WebKit/chromium

Files:

• ChangeLog (modified) (1 diff)
• public/WebDevToolsFrontendClient.h (modified) (2 diffs)
• src/InspectorFrontendClientImpl.cpp (modified) (2 diffs)

trunk/Source/WebKit/chromium/ChangeLog

@@ +1 @@
+2011-11-09  Alexei Svitkine  <asvitkine@chromium.org>
+
+        Chromium: Add plumbing to enable dragging dev tools via the empty space on the toolbar.
+        https://bugs.webkit.org/show_bug.cgi?id=71842
+
+        These are the only WebKit-side changes needed. The rest will be done on the Chromium side.
+
+        Chromium bug: http://crbug.com/44350
+
+        Reviewed by Pavel Feldman.
+
+        * public/WebDevToolsFrontendClient.h:
+        (WebKit::WebDevToolsFrontendClient::moveWindowBy):
+        * src/InspectorFrontendClientImpl.cpp:
+        (WebKit::InspectorFrontendClientImpl::moveWindowBy):
+
 2011-11-08  Jay Civelli  <jcivelli@chromium.org>
 

trunk/Source/WebKit/chromium/public/WebDevToolsFrontendClient.h

@@ -35 +35 @@
 
 class WebString;
+struct WebFloatPoint;
 struct WebDevToolsMessageData;
 
@@ -50 +51 @@
     virtual void requestDockWindow() { }
     virtual void requestUndockWindow() { }
+    virtual void moveWindowBy(const WebFloatPoint&) { }
     virtual void saveAs(const WebString& fileName, const WebString& content) { }
 

trunk/Source/WebKit/chromium/src/InspectorFrontendClientImpl.cpp

@@ -41 +41 @@
 #include "WebDevToolsFrontendClient.h"
 #include "WebDevToolsFrontendImpl.h"
+#include "WebFloatPoint.h"
 #include "WebString.h"
 
@@ -82 +83 @@
 void InspectorFrontendClientImpl::moveWindowBy(float x, float y)
 {
+    m_client->moveWindowBy(WebFloatPoint(x, y));
 }