Changeset 99747 in webkit


Ignore:
Timestamp:
Nov 9, 2011, 12:05:40 PM (14 years ago)
Author:
haraken@chromium.org
Message:

Generate the HTMLOptionElement constructor using [NamedConstructor] IDL
​https://bugs.webkit.org/show_bug.cgi?id=71925

Reviewed by Adam Barth.

This patch removes a custom constructor of HTMLOptionElement,
and generates it using [NamedConstructor] IDL.

Tests: fast/js/custom-constructors.html

fast/forms/option-index.html
fast/forms/add-and-remove-option.html
fast/dom/dom-add-optionelement.html

  • Target.pri: Removed V8HTMLOptionElementConstructor.{h,cpp}
  • WebCore.gypi: Ditto.
  • bindings/v8/custom/V8HTMLOptionElementConstructor.cpp: Removed.
  • bindings/v8/custom/V8HTMLOptionElementConstructor.h: Removed.
  • html/HTMLOptionElement.idl: Added [NamedConstructor] IDL.
  • page/DOMWindow.idl: Removed [V8CustomConstructor] IDL.
Location:
trunk/Source/WebCore
Files:
2 deleted
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r99744 r99747  
     12011-11-09  Kentaro Hara  <haraken@chromium.org>
     2
     3        Generate the HTMLOptionElement constructor using [NamedConstructor] IDL
     4        https://bugs.webkit.org/show_bug.cgi?id=71925
     5
     6        Reviewed by Adam Barth.
     7
     8        This patch removes a custom constructor of HTMLOptionElement,
     9        and generates it using [NamedConstructor] IDL.
     10
     11        Tests: fast/js/custom-constructors.html
     12               fast/forms/option-index.html
     13               fast/forms/add-and-remove-option.html
     14               fast/dom/dom-add-optionelement.html
     15
     16        * Target.pri: Removed V8HTMLOptionElementConstructor.{h,cpp}
     17        * WebCore.gypi: Ditto.
     18        * bindings/v8/custom/V8HTMLOptionElementConstructor.cpp: Removed.
     19        * bindings/v8/custom/V8HTMLOptionElementConstructor.h: Removed.
     20        * html/HTMLOptionElement.idl: Added [NamedConstructor] IDL.
     21        * page/DOMWindow.idl: Removed [V8CustomConstructor] IDL.
     22
    1232011-11-09  Julien Chaffraix  <jchaffraix@webkit.org>
    224

  • trunk/Source/WebCore/Target.pri

    r99718 r99747  
    199199        bindings/v8/custom/V8HTMLInputElementCustom.cpp \
    200200        bindings/v8/custom/V8HTMLLinkElementCustom.cpp \
    201         bindings/v8/custom/V8HTMLOptionElementConstructor.cpp \
    202201        bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp \
    203202        bindings/v8/custom/V8HTMLOutputElementCustom.cpp \
    … …  
    13531352        bindings/v8/custom/V8HTMLAudioElementConstructor.h \
    13541353        bindings/v8/custom/V8HTMLImageElementConstructor.h \
    1355         bindings/v8/custom/V8HTMLOptionElementConstructor.h \
    13561354        bindings/v8/custom/V8HTMLSelectElementCustom.h \
    13571355        bindings/v8/custom/V8MessagePortCustom.h \

  • trunk/Source/WebCore/WebCore.gypi

    r99695 r99747  
    22012201            'bindings/v8/custom/V8HTMLInputElementCustom.cpp',
    22022202            'bindings/v8/custom/V8HTMLLinkElementCustom.cpp',
    2203             'bindings/v8/custom/V8HTMLOptionElementConstructor.cpp',
    2204             'bindings/v8/custom/V8HTMLOptionElementConstructor.h',
    22052203            'bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp',
    22062204            'bindings/v8/custom/V8HTMLOutputElementCustom.cpp',

  • trunk/Source/WebCore/html/HTMLOptionElement.idl

    r99510 r99747  
    2222
    2323    interface [
    24         GenerateNativeConverter
     24        GenerateNativeConverter,
     25        NamedConstructor=Option(in [Optional=CallWithNullValue] DOMString data, in [Optional=CallWithNullValue] DOMString value, in [Optional=CallWithDefaultValue] boolean defaultSelected, in [Optional=CallWithDefaultValue] boolean selected),
     26        ConstructorRaisesException
    2527    ] HTMLOptionElement : HTMLElement {
    2628        readonly attribute HTMLFormElement form;

  • trunk/Source/WebCore/page/DOMWindow.idl

    r99641 r99747  
    492492
    493493        attribute [JSCCustomGetter, CustomConstructor] HTMLImageElementConstructorConstructor Image; // Usable with new operator
    494         attribute [JSCCustomGetter, CustomConstructor] HTMLOptionElementConstructorConstructor Option; // Usable with new operator
     494        attribute [JSCCustomGetter, JSCustomConstructor] HTMLOptionElementConstructorConstructor Option; // Usable with new operator
    495495
    496496        attribute CanvasPatternConstructor CanvasPattern;
Note: See TracChangeset for help on using the changeset viewer.