Changeset 100013 in webkit


Ignore:
Timestamp:
Nov 11, 2011 1:58:49 PM (12 years ago)
Author:
commit-queue@webkit.org
Message:

Access key should work on all elements.
https://bugs.webkit.org/show_bug.cgi?id=71854

Patch by Vineet Chaudhary <vineet.chaudhary@motorola.com> on 2011-11-11
Reviewed by Adam Barth.

Source/WebCore:

As per specification http://dev.w3.org/html5/spec/Overview.html#elements-in-the-dom
says All HTML elements can have the accesskey content attribute set. Adding "accessKey"
attribute idl file as [Reflect].

Test: fast/forms/access-key-for-all-elements.html

  • html/HTMLAnchorElement.idl: Removed redundant IDL attribute entries.
  • html/HTMLAreaElement.idl: Ditto.
  • html/HTMLButtonElement.idl: Ditto.
  • html/HTMLElement.idl: Added accessKey IDL attribute.
  • html/HTMLInputElement.idl: Ditto.
  • html/HTMLLabelElement.idl: Ditto.
  • html/HTMLLegendElement.idl: Ditto.
  • html/HTMLTextAreaElement.idl: Ditto.

LayoutTests:

Added test case to check whether all elements can also have accessKey attribute.

  • fast/forms/access-key-for-all-elements-expected.txt: Added.
  • fast/forms/access-key-for-all-elements.html: Added.
Location:
trunk
Files:
2 added
10 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r100012 r100013  
     12011-11-11  Vineet Chaudhary  <vineet.chaudhary@motorola.com>
     2
     3        Access key should work on all elements.
     4        https://bugs.webkit.org/show_bug.cgi?id=71854
     5
     6        Reviewed by Adam Barth.
     7
     8        Added test case to check whether all elements can also have accessKey attribute.
     9
     10        * fast/forms/access-key-for-all-elements-expected.txt: Added.
     11        * fast/forms/access-key-for-all-elements.html: Added.
     12
    1132011-11-11  Ben Wells  <benwells@chromium.org>
    214
  • trunk/Source/WebCore/ChangeLog

    r100006 r100013  
     12011-11-11  Vineet Chaudhary  <vineet.chaudhary@motorola.com>
     2
     3        Access key should work on all elements.
     4        https://bugs.webkit.org/show_bug.cgi?id=71854
     5
     6        Reviewed by Adam Barth.
     7
     8        As per specification http://dev.w3.org/html5/spec/Overview.html#elements-in-the-dom
     9        says All HTML elements can have the accesskey content attribute set. Adding "accessKey"
     10        attribute idl file as [Reflect].
     11
     12        Test: fast/forms/access-key-for-all-elements.html
     13
     14        * html/HTMLAnchorElement.idl: Removed redundant IDL attribute entries.
     15        * html/HTMLAreaElement.idl: Ditto.
     16        * html/HTMLButtonElement.idl: Ditto.
     17        * html/HTMLElement.idl: Added accessKey IDL attribute.
     18        * html/HTMLInputElement.idl: Ditto.
     19        * html/HTMLLabelElement.idl: Ditto.
     20        * html/HTMLLegendElement.idl: Ditto.
     21        * html/HTMLTextAreaElement.idl: Ditto.
     22
    1232011-11-11  Mark Hahnenberg  <mhahnenberg@apple.com>
    224
  • trunk/Source/WebCore/html/HTMLAnchorElement.idl

    r92327 r100013  
    2222
    2323    interface HTMLAnchorElement : HTMLElement {
    24         attribute [Reflect] DOMString accessKey;
    2524        attribute [Reflect] DOMString charset;
    2625        attribute [Reflect] DOMString coords;
  • trunk/Source/WebCore/html/HTMLAreaElement.idl

    r89269 r100013  
    2222
    2323    interface HTMLAreaElement : HTMLElement {
    24         attribute [Reflect] DOMString accessKey;
    2524        attribute [Reflect] DOMString alt;
    2625        attribute [Reflect] DOMString coords;
  • trunk/Source/WebCore/html/HTMLButtonElement.idl

    r96484 r100013  
    3131        readonly attribute ValidityState validity;
    3232
    33         attribute [Reflect] DOMString accessKey;
    3433        attribute [Reflect] boolean disabled;
    3534        attribute [Reflect] boolean autofocus;
  • trunk/Source/WebCore/html/HTMLElement.idl

    r98888 r100013  
    3838                 attribute [Reflect] DOMString webkitdropzone;
    3939                 attribute [Reflect] boolean hidden;
     40                 attribute [Reflect] DOMString accessKey;
    4041
    4142        // Extensions
  • trunk/Source/WebCore/html/HTMLInputElement.idl

    r99821 r100013  
    3232        readonly attribute ValidityState validity;
    3333        attribute [Reflect] DOMString accept;
    34         attribute [Reflect] DOMString accessKey;
    3534        attribute [Reflect] DOMString align;
    3635        attribute [Reflect] DOMString alt;
  • trunk/Source/WebCore/html/HTMLLabelElement.idl

    r89269 r100013  
    2323    interface HTMLLabelElement : HTMLElement {
    2424        readonly attribute HTMLFormElement form;
    25         attribute [Reflect] DOMString accessKey;
    2625        attribute [Reflect=for] DOMString htmlFor;
    2726        readonly attribute HTMLElement control;
  • trunk/Source/WebCore/html/HTMLLegendElement.idl

    r89269 r100013  
    2323    interface HTMLLegendElement : HTMLElement {
    2424        readonly attribute HTMLFormElement form;
    25         attribute [Reflect] DOMString accessKey;
    2625        attribute [Reflect] DOMString align;
    2726    };
  • trunk/Source/WebCore/html/HTMLTextAreaElement.idl

    r99821 r100013  
    2626        readonly attribute HTMLFormElement form;
    2727        readonly attribute ValidityState validity;
    28         attribute [Reflect] DOMString accessKey;
    2928        attribute long cols;
    3029        attribute [Reflect] boolean disabled;
Note: See TracChangeset for help on using the changeset viewer.