Changeset 100251 in webkit

Timestamp:

Nov 15, 2011 1:32:16 AM (13 years ago)

Author:

apavlov@chromium.org

Message:

Web Inspector: [Crash] Crash when inspecting namespaced SVG styled via element names
​https://bugs.webkit.org/show_bug.cgi?id=72261

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/styles/svg-style.xhtml

• inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheet::inlineStyleSheetText):

LayoutTests:

• inspector/styles/svg-style-expected.txt: Added.
• inspector/styles/svg-style.xhtml: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/inspector/styles/svg-style-expected.txt (added)
• LayoutTests/inspector/styles/svg-style.xhtml (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/inspector/InspectorStyleSheet.cpp (modified) (3 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-11-14  Alexander Pavlov  <apavlov@chromium.org>
+
+        Web Inspector: [Crash] Crash when inspecting namespaced SVG styled via element names
+        https://bugs.webkit.org/show_bug.cgi?id=72261
+
+        Reviewed by Pavel Feldman.
+
+        * inspector/styles/svg-style-expected.txt: Added.
+        * inspector/styles/svg-style.xhtml: Added.
+
 2011-11-15  Czene Tamás  <tczene@inf.u-szeged.hu>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-11-14  Alexander Pavlov  <apavlov@chromium.org>
+
+        Web Inspector: [Crash] Crash when inspecting namespaced SVG styled via element names
+        https://bugs.webkit.org/show_bug.cgi?id=72261
+
+        Reviewed by Pavel Feldman.
+
+        Test: inspector/styles/svg-style.xhtml
+
+        * inspector/InspectorStyleSheet.cpp:
+        (WebCore::InspectorStyleSheet::inlineStyleSheetText):
+
 2011-11-15  Kent Tamura  <tkent@chromium.org>
 

trunk/Source/WebCore/inspector/InspectorStyleSheet.cpp

@@ -40 +40 @@
 #include "Element.h"
 #include "HTMLHeadElement.h"
+#include "HTMLNames.h"
 #include "HTMLParserIdioms.h"
 #include "InspectorCSSAgent.h"
@@ -45 +46 @@
 #include "InspectorValues.h"
 #include "Node.h"
+#include "SVGNames.h"
 #include "StyleSheetList.h"
 #include "WebKitCSSKeyframesRule.h"
@@ -1103 +1105 @@
         return false;
     Element* ownerElement = static_cast<Element*>(ownerNode);
-    if (ownerElement->tagName().lower() != "style")
+
+    if (!ownerElement->hasTagName(HTMLNames::styleTag)
+#if ENABLE(SVG)
+        && !ownerElement->hasTagName(SVGNames::styleTag)
+#endif
+    )
         return false;
     *result = ownerElement->innerText();