Changeset 100727 in webkit


Ignore:
Timestamp:
Nov 17, 2011 10:57:05 PM (12 years ago)
Author:
commit-queue@webkit.org
Message:

Remove initProgressEvent method
​https://bugs.webkit.org/show_bug.cgi?id=71340

Patch by Kaustubh Atrawalkar <Kaustubh Atrawalkar> on 2011-11-17
Reviewed by Adam Barth.

This method has been removed from the spec draft.
​http://www.w3.org/TR/progress-events/#interface-progressevent

Source/WebCore:

No new tests. Removed method.

  • dom/ProgressEvent.cpp:
  • dom/ProgressEvent.h:
  • dom/ProgressEvent.idl:

LayoutTests:

No new tests. Removed method. Updated expected results.

  • fast/dom/non-numeric-values-numeric-parameters-expected.txt:
  • fast/dom/script-tests/non-numeric-values-numeric-parameters.js:
  • fast/events/init-events-expected.txt:
  • fast/events/script-tests/init-events.js:
  • fast/xmlhttprequest/xmlhttprequest-get-expected.txt:
  • platform/chromium-cg-mac/fast/xmlhttprequest/xmlhttprequest-get-expected.txt:
  • platform/chromium-mac/fast/xmlhttprequest/xmlhttprequest-get-expected.txt:
  • platform/chromium-win/fast/xmlhttprequest/xmlhttprequest-get-expected.txt:
Location:
trunk
Files:
13 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r100721 r100727  
     12011-11-17  Kaustubh Atrawalkar  <kaustubh@motorola.com>
     2
     3        Remove initProgressEvent method
     4        https://bugs.webkit.org/show_bug.cgi?id=71340
     5
     6        Reviewed by Adam Barth.
     7
     8        This method has been removed from the spec draft.
     9        http://www.w3.org/TR/progress-events/#interface-progressevent
     10
     11        No new tests. Removed method. Updated expected results.
     12
     13        * fast/dom/non-numeric-values-numeric-parameters-expected.txt:
     14        * fast/dom/script-tests/non-numeric-values-numeric-parameters.js:
     15        * fast/events/init-events-expected.txt:
     16        * fast/events/script-tests/init-events.js:
     17        * fast/xmlhttprequest/xmlhttprequest-get-expected.txt:
     18        * platform/chromium-cg-mac/fast/xmlhttprequest/xmlhttprequest-get-expected.txt:
     19        * platform/chromium-mac/fast/xmlhttprequest/xmlhttprequest-get-expected.txt:
     20        * platform/chromium-win/fast/xmlhttprequest/xmlhttprequest-get-expected.txt:
     21
    1222011-11-17  Adam Klein  <adamk@chromium.org>
    223

  • trunk/LayoutTests/fast/dom/non-numeric-values-numeric-parameters-expected.txt

    r29963 r100727  
    5252PASS nonNumericPolicy('document.createNodeIterator(document, x, null, false)') is 'any type allowed'
    5353PASS nonNumericPolicy('document.getElementsByTagName("div").item(x)') is 'any type allowed'
    54 PASS nonNumericPolicy('document.createEvent("ProgressEvent").initProgressEvent("a", false, false, false, x, 0)') is 'any type allowed'
    55 PASS nonNumericPolicy('document.createEvent("ProgressEvent").initProgressEvent("a", false, false, false, 0, x)') is 'any type allowed'
    5654PASS nonNumericPolicy('document.createRange().setStart(document, x)') is 'any type allowed'
    5755PASS nonNumericPolicy('document.createRange().setEnd(document, x)') is 'any type allowed'

  • trunk/LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js

    r98407 r100727  
    301301
    302302shouldBe("nonNumericPolicy('document.getElementsByTagName(\"div\").item(x)')", "'any type allowed'");
    303 
    304 // ProgressEvent
    305 
    306 shouldBe("nonNumericPolicy('document.createEvent(\"ProgressEvent\").initProgressEvent(\"a\", false, false, false, x, 0)')", "'any type allowed'");
    307 shouldBe("nonNumericPolicy('document.createEvent(\"ProgressEvent\").initProgressEvent(\"a\", false, false, false, 0, x)')", "'any type allowed'");
    308303
    309304// Range

  • trunk/LayoutTests/fast/events/init-events-expected.txt

    r99435 r100727  
    117117PASS testInitEvent('Mutation', '"a", false, false, null, "b", "c", null, 1001').attrName is 'null'
    118118PASS testInitEvent('Mutation', '"a", false, false, null, "b", "c", "d", 1001').attrChange is 1001
    119 PASS testInitEvent('Progress', '"a", false, false, false, 1001, 1002').type is 'a'
    120 PASS testInitEvent('Progress', 'null, false, false, false, 1001, 1002').type is 'null'
    121 PASS testInitEvent('Progress', '"a", false, false, false, 1001, 1002').bubbles is false
    122 PASS testInitEvent('Progress', '"a", true, false, false, 1001, 1002').bubbles is true
    123 PASS testInitEvent('Progress', '"a", false, false, false, 1001, 1002').cancelable is false
    124 PASS testInitEvent('Progress', '"a", false, true, false, 1001, 1002').cancelable is true
    125 PASS testInitEvent('Progress', '"a", false, false, false, 1001, 1002').lengthComputable is false
    126 PASS testInitEvent('Progress', '"a", false, false, true, 1001, 1002').lengthComputable is true
    127 PASS testInitEvent('Progress', '"a", false, false, false, 1001, 1002').loaded is 1001
    128 PASS testInitEvent('Progress', '"a", false, false, false, 1001, 1002').total is 1002
    129119PASS testInitEvent('Storage', '"a", false, false, "b", "c", "d", "e"').type is 'a'
    130120PASS testInitEvent('Storage', 'null, false, false, "b", "c", "d", "e"').type is 'null'

  • trunk/LayoutTests/fast/events/script-tests/init-events.js

    r99435 r100727  
    131131shouldBe("testInitEvent('Mutation', '\"a\", false, false, null, \"b\", \"c\", \"d\", 1001').attrChange", "1001");
    132132
    133 shouldBe("testInitEvent('Progress', '\"a\", false, false, false, 1001, 1002').type", "'a'");
    134 shouldBe("testInitEvent('Progress', 'null, false, false, false, 1001, 1002').type", "'null'");
    135 shouldBe("testInitEvent('Progress', '\"a\", false, false, false, 1001, 1002').bubbles", "false");
    136 shouldBe("testInitEvent('Progress', '\"a\", true, false, false, 1001, 1002').bubbles", "true");
    137 shouldBe("testInitEvent('Progress', '\"a\", false, false, false, 1001, 1002').cancelable", "false");
    138 shouldBe("testInitEvent('Progress', '\"a\", false, true, false, 1001, 1002').cancelable", "true");
    139 shouldBe("testInitEvent('Progress', '\"a\", false, false, false, 1001, 1002').lengthComputable", "false");
    140 shouldBe("testInitEvent('Progress', '\"a\", false, false, true, 1001, 1002').lengthComputable", "true");
    141 shouldBe("testInitEvent('Progress', '\"a\", false, false, false, 1001, 1002').loaded", "1001");
    142 shouldBe("testInitEvent('Progress', '\"a\", false, false, false, 1001, 1002').total", "1002");
    143 
    144133shouldBe("testInitEvent('Storage', '\"a\", false, false, \"b\", \"c\", \"d\", \"e\"').type", "'a'");
    145134shouldBe("testInitEvent('Storage', 'null, false, false, \"b\", \"c\", \"d\", \"e\"').type", "'null'");

  • trunk/LayoutTests/fast/xmlhttprequest/xmlhttprequest-get-expected.txt

    r56203 r100727  
    5353    [native code]
    5454}'
    55 initProgressEvent : 'function initProgressEvent() {
    56     [native code]
    57 }'
    5855lengthComputable : 'false'
    5956loaded : '0'

  • trunk/LayoutTests/platform/chromium-cg-mac/fast/xmlhttprequest/xmlhttprequest-get-expected.txt

    r74097 r100727  
    5151eventPhase : '2'
    5252initEvent : 'function initEvent() { [native code] }'
    53 initProgressEvent : 'function initProgressEvent() { [native code] }'
    5453lengthComputable : 'false'
    5554loaded : '0'

  • trunk/LayoutTests/platform/chromium-mac/fast/xmlhttprequest/xmlhttprequest-get-expected.txt

    r94341 r100727  
    5151eventPhase : '2'
    5252initEvent : 'function initEvent() { [native code] }'
    53 initProgressEvent : 'function initProgressEvent() { [native code] }'
    5453lengthComputable : 'false'
    5554loaded : '0'

  • trunk/LayoutTests/platform/chromium-win/fast/xmlhttprequest/xmlhttprequest-get-expected.txt

    r74097 r100727  
    5151eventPhase : '2'
    5252initEvent : 'function initEvent() { [native code] }'
    53 initProgressEvent : 'function initProgressEvent() { [native code] }'
    5453lengthComputable : 'false'
    5554loaded : '0'

  • trunk/Source/WebCore/ChangeLog

    r100726 r100727  
     12011-11-17  Kaustubh Atrawalkar  <kaustubh@motorola.com>
     2
     3        Remove initProgressEvent method
     4        https://bugs.webkit.org/show_bug.cgi?id=71340
     5
     6        Reviewed by Adam Barth.
     7
     8        This method has been removed from the spec draft.
     9        http://www.w3.org/TR/progress-events/#interface-progressevent
     10
     11        No new tests. Removed method.
     12
     13        * dom/ProgressEvent.cpp:
     14        * dom/ProgressEvent.h:
     15        * dom/ProgressEvent.idl:
     16
    1172011-11-17  Eunmi Lee  <eunmi15.lee@samsung.com>
    218

  • trunk/Source/WebCore/dom/ProgressEvent.cpp

    r98044 r100727  
    6161}
    6262   
    63 void ProgressEvent::initProgressEvent(const AtomicString& typeArg, bool canBubbleArg, bool cancelableArg,
    64     bool lengthComputableArg, unsigned long long loadedArg, unsigned long long totalArg)
    65 {   
    66     if (dispatched())
    67         return;
    68 
    69     initEvent(typeArg, canBubbleArg, cancelableArg);
    70 
    71     m_lengthComputable = lengthComputableArg;
    72     m_loaded = loadedArg;
    73     m_total = totalArg;
    74 }
    75 
    7663const AtomicString& ProgressEvent::interfaceName() const
    7764{

  • trunk/Source/WebCore/dom/ProgressEvent.h

    r98146 r100727  
    5454    }
    5555
    56     void initProgressEvent(const AtomicString& typeArg, bool canBubbleArg, bool cancelableArg,
    57         bool lengthComputableArg, unsigned long long loadedArg, unsigned long long totalArg);
    58 
    5956    bool lengthComputable() const { return m_lengthComputable; }
    6057    unsigned long long loaded() const { return m_loaded; }

  • trunk/Source/WebCore/dom/ProgressEvent.idl

    r100564 r100727  
    3232        readonly attribute [InitializedByConstructor] unsigned long long loaded;
    3333        readonly attribute [InitializedByConstructor] unsigned long long total;
    34 
    35         void initProgressEvent(in [Optional=CallWithDefaultValue] DOMString typeArg,
    36                                in [Optional=CallWithDefaultValue] boolean canBubbleArg,
    37                                in [Optional=CallWithDefaultValue] boolean cancelableArg,
    38                                in [Optional=CallWithDefaultValue] boolean lengthComputableArg,
    39                                in [Optional=CallWithDefaultValue] unsigned long long loadedArg,
    40                                in [Optional=CallWithDefaultValue] unsigned long long totalArg);
    4134    };
    4235
Note: See TracChangeset for help on using the changeset viewer.