Changeset 100847 in webkit


Ignore:
Timestamp:
Nov 18, 2011 10:05:05 PM (12 years ago)
Author:
commit-queue@webkit.org
Message:

https://bugs.webkit.org/show_bug.cgi?id=72591
Remove document.width / document.height

Patch by Vineet Chaudhary <vineet.chaudhary@motorola.com> on 2011-11-18
Reviewed by Darin Adler.

Source/WebCore:

Removed document.width/document.height from JS bindings,
but keeping the same for ObjC bindings. Also it should use
document.body.clientWidth and document.body.clientHeight instead.

  • html/HTMLDocument.idl:

LayoutTests:

As support for document.width / document.height has been
removed it should use document.body.clientWidth and document.body.clientHeight
respectively.

  • fast/dom/document-width-height-force-layout-expected.txt:
  • fast/dom/document-width-height-force-layout.html:

Modified test case to use document.body.clientWidth and document.body.clientHeight.

  • fullscreen/video-specified-size-expected.txt:
  • fullscreen/video-specified-size.html:

Modified test case to use document.body.clientWidth.

Location:
trunk
Files:
7 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r100845 r100847  
     12011-11-18  Vineet Chaudhary  <vineet.chaudhary@motorola.com>
     2
     3        https://bugs.webkit.org/show_bug.cgi?id=72591
     4        Remove document.width / document.height
     5
     6        Reviewed by Darin Adler.
     7
     8        As support for document.width / document.height has been
     9        removed it should use document.body.clientWidth and document.body.clientHeight
     10        respectively.
     11
     12        * fast/dom/document-width-height-force-layout-expected.txt:
     13        * fast/dom/document-width-height-force-layout.html:
     14        Modified test case to use document.body.clientWidth and document.body.clientHeight.
     15        * fullscreen/video-specified-size-expected.txt:
     16        * fullscreen/video-specified-size.html:
     17        Modified test case to use document.body.clientWidth.
     18
    1192011-11-18  Yuta Kitamura  <yutak@chromium.org>
    220
  • trunk/LayoutTests/fast/dom/document-width-height-force-layout-expected.txt

    r30635 r100847  
    1 This tests that document.width and document.height cause a layout on use. The test has passed if they have positive values.
     1This tests that document.body.clientWidth and document.body.clientHeight cause a layout on use. The test has passed if they have positive values.
    22
    3 document.width = 800
    4 document.height = 600
     3document.body.clientWidth = 800
     4document.body.clientHeight = 600
    55
  • trunk/LayoutTests/fast/dom/document-width-height-force-layout.html

    r25591 r100847  
    1212                layoutTestController.dumpAsText();
    1313
    14             log("document.width = " + document.width);
    15             log("document.height = " + document.height);
     14            log("document.body.clientWidth = " + document.body.clientWidth);
     15            log("document.body.clientHeight = " + document.body.clientHeight);
    1616        }
    1717    </script>
    1818</head>
    1919<body onload="test()">
    20     <p>This tests that document.width and document.height cause a layout on use.  The test has passed if they have positive values.</p>
     20    <p>This tests that document.body.clientWidth and document.body.clientHeight cause a layout on use.  The test has passed if they have positive values.</p>
    2121    <pre id="console"></pre>
    2222</body>
  • trunk/LayoutTests/fullscreen/video-specified-size-expected.txt

    r83654 r100847  
    1 EVENT(webkitfullscreenchange) TEST(video.clientWidth==document.width) OK
     1EVENT(webkitfullscreenchange) TEST(video.clientWidth==document.body.clientWidth) OK
    22END OF TEST
    33
  • trunk/LayoutTests/fullscreen/video-specified-size.html

    r83654 r100847  
    66        setSrcById("video", findMediaFile("video", "../media/content/test"));
    77        var video = document.getElementById('video');
    8 
    98        // Bail out early if the full screen API is not enabled or is missing:
    109        if (Element.prototype.webkitRequestFullScreen == undefined) {
     
    1211            endTest();
    1312        } else {
    14             waitForEventTestAndEnd(document, 'webkitfullscreenchange', "video.clientWidth==document.width");
     13            waitForEventTestAndEnd(document, 'webkitfullscreenchange', "video.clientWidth==document.body.clientWidth");
    1514            runWithKeyDown(function(){video.webkitRequestFullScreen()});
    1615        }
  • trunk/Source/WebCore/ChangeLog

    r100846 r100847  
     12011-11-18  Vineet Chaudhary  <vineet.chaudhary@motorola.com>
     2
     3        https://bugs.webkit.org/show_bug.cgi?id=72591
     4        Remove document.width / document.height
     5
     6        Reviewed by Darin Adler.
     7
     8        Removed document.width/document.height from JS bindings,
     9        but keeping the same for ObjC bindings. Also it should use
     10        document.body.clientWidth and document.body.clientHeight instead.
     11
     12        * html/HTMLDocument.idl:
     13
    1142011-11-18  Martin Robinson  <mrobinson@igalia.com>
    215
  • trunk/Source/WebCore/html/HTMLDocument.idl

    r92327 r100847  
    4545        void releaseEvents();
    4646
     47#if defined(LANGUAGE_OBJECTIVE_C) && LANGUAGE_OBJECTIVE_C
    4748        readonly attribute long width;
    4849        readonly attribute long height;
     50#endif
    4951                 attribute [ConvertNullToNullString] DOMString dir;
    5052                 attribute [ConvertNullToNullString] DOMString designMode;
Note: See TracChangeset for help on using the changeset viewer.