Changeset 101453 in webkit
- Timestamp:
- Nov 30, 2011 12:07:45 AM (12 years ago)
- Location:
- trunk
- Files:
-
- 9 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r101452 r101453 1 2011-11-29 Kentaro Hara <haraken@chromium.org> 2 3 StorageEvent.key should not be nullable 4 https://bugs.webkit.org/show_bug.cgi?id=73125 5 6 Reviewed by Adam Barth. 7 8 Currently, document.createEvent('StorageEvent').key is evaluated as null. 9 However, the spec (http://www.whatwg.org/specs/web-apps/current-work/#storageevent) 10 says that StorageEvent.key is not a nullable type, and thus 11 document.createEvent('StorageEvent').key should be '' (an empty string). 12 13 * storage/domstorage/events/basic-body-attribute-expected.txt: Updated the test result as described above. 14 * storage/domstorage/events/basic-expected.txt: Ditto. 15 * storage/domstorage/events/basic-setattribute-expected.txt: Ditto. 16 * storage/domstorage/events/script-tests/basic-body-attribute.js: Ditto. 17 (step6): 18 * storage/domstorage/events/script-tests/basic-setattribute.js: Ditto. 19 (step6): 20 * storage/domstorage/events/script-tests/basic.js: Ditto. 21 (step6): 22 1 23 2011-11-29 Philip Rogers <pdr@google.com> 2 24 -
trunk/LayoutTests/storage/domstorage/events/basic-body-attribute-expected.txt
r53840 r101453 45 45 storage.clear() 46 46 PASS storageEventList.length is 8 47 PASS storageEventList[7].key is null47 PASS storageEventList[7].key is "" 48 48 PASS storageEventList[7].oldValue is null 49 49 PASS storageEventList[7].newValue is null … … 91 91 storage.clear() 92 92 PASS storageEventList.length is 8 93 PASS storageEventList[7].key is null93 PASS storageEventList[7].key is "" 94 94 PASS storageEventList[7].oldValue is null 95 95 PASS storageEventList[7].newValue is null -
trunk/LayoutTests/storage/domstorage/events/basic-expected.txt
r53840 r101453 43 43 storage.clear() 44 44 PASS storageEventList.length is 8 45 PASS storageEventList[7].key is null45 PASS storageEventList[7].key is "" 46 46 PASS storageEventList[7].oldValue is null 47 47 PASS storageEventList[7].newValue is null … … 87 87 storage.clear() 88 88 PASS storageEventList.length is 8 89 PASS storageEventList[7].key is null89 PASS storageEventList[7].key is "" 90 90 PASS storageEventList[7].oldValue is null 91 91 PASS storageEventList[7].newValue is null -
trunk/LayoutTests/storage/domstorage/events/basic-setattribute-expected.txt
r53840 r101453 45 45 storage.clear() 46 46 PASS storageEventList.length is 8 47 PASS storageEventList[7].key is null47 PASS storageEventList[7].key is "" 48 48 PASS storageEventList[7].oldValue is null 49 49 PASS storageEventList[7].newValue is null … … 91 91 storage.clear() 92 92 PASS storageEventList.length is 8 93 PASS storageEventList[7].key is null93 PASS storageEventList[7].key is "" 94 94 PASS storageEventList[7].oldValue is null 95 95 PASS storageEventList[7].newValue is null -
trunk/LayoutTests/storage/domstorage/events/script-tests/basic-body-attribute.js
r86408 r101453 87 87 { 88 88 shouldBe("storageEventList.length", "8"); 89 shouldBe Null("storageEventList[7].key");89 shouldBeEqualToString("storageEventList[7].key", ""); 90 90 shouldBeNull("storageEventList[7].oldValue"); 91 91 shouldBeNull("storageEventList[7].newValue"); -
trunk/LayoutTests/storage/domstorage/events/script-tests/basic-setattribute.js
r86408 r101453 87 87 { 88 88 shouldBe("storageEventList.length", "8"); 89 shouldBe Null("storageEventList[7].key");89 shouldBeEqualToString("storageEventList[7].key", ""); 90 90 shouldBeNull("storageEventList[7].oldValue"); 91 91 shouldBeNull("storageEventList[7].newValue"); -
trunk/LayoutTests/storage/domstorage/events/script-tests/basic.js
r86408 r101453 87 87 { 88 88 shouldBe("storageEventList.length", "8"); 89 shouldBe Null("storageEventList[7].key");89 shouldBeEqualToString("storageEventList[7].key", ""); 90 90 shouldBeNull("storageEventList[7].oldValue"); 91 91 shouldBeNull("storageEventList[7].newValue"); -
trunk/Source/WebCore/ChangeLog
r101452 r101453 1 2011-11-29 Kentaro Hara <haraken@chromium.org> 2 3 StorageEvent.key should not be nullable 4 https://bugs.webkit.org/show_bug.cgi?id=73125 5 6 Reviewed by Adam Barth. 7 8 Currently, document.createEvent('StorageEvent').key is evaluated as null. 9 However, the spec (http://www.whatwg.org/specs/web-apps/current-work/#storageevent) 10 says that StorageEvent.key is not a nullable type, and thus 11 document.createEvent('StorageEvent').key should be '' (an empty string). 12 13 * storage/StorageEvent.idl: Removed a [ConvertNullStringTo=Null] IDL from StorageEvent.key. 14 1 15 2011-11-29 Philip Rogers <pdr@google.com> 2 16 -
trunk/Source/WebCore/storage/StorageEvent.idl
r97574 r101453 27 27 28 28 interface StorageEvent : Event { 29 readonly attribute [ConvertNullStringTo=Null]DOMString key;29 readonly attribute DOMString key; 30 30 readonly attribute [ConvertNullStringTo=Null] DOMString oldValue; 31 31 readonly attribute [ConvertNullStringTo=Null] DOMString newValue;
Note: See TracChangeset
for help on using the changeset viewer.