Changeset 101453 in webkit


Ignore:
Timestamp:
Nov 30, 2011 12:07:45 AM (12 years ago)
Author:
haraken@chromium.org
Message:

StorageEvent.key should not be nullable
https://bugs.webkit.org/show_bug.cgi?id=73125

Reviewed by Adam Barth.

Currently, document.createEvent('StorageEvent').key is evaluated as null.
However, the spec (http://www.whatwg.org/specs/web-apps/current-work/#storageevent)
says that StorageEvent.key is not a nullable type, and thus
document.createEvent('StorageEvent').key should be (an empty string).

Source/WebCore:

  • storage/StorageEvent.idl: Removed a [ConvertNullStringTo=Null] IDL from StorageEvent.key.

LayoutTests:

  • storage/domstorage/events/basic-body-attribute-expected.txt: Updated the test result as described above.
  • storage/domstorage/events/basic-expected.txt: Ditto.
  • storage/domstorage/events/basic-setattribute-expected.txt: Ditto.
  • storage/domstorage/events/script-tests/basic-body-attribute.js: Ditto.

(step6):

  • storage/domstorage/events/script-tests/basic-setattribute.js: Ditto.

(step6):

  • storage/domstorage/events/script-tests/basic.js: Ditto.

(step6):

Location:
trunk
Files:
9 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r101452 r101453  
     12011-11-29  Kentaro Hara  <haraken@chromium.org>
     2
     3        StorageEvent.key should not be nullable
     4        https://bugs.webkit.org/show_bug.cgi?id=73125
     5
     6        Reviewed by Adam Barth.
     7
     8        Currently, document.createEvent('StorageEvent').key is evaluated as null.
     9        However, the spec (http://www.whatwg.org/specs/web-apps/current-work/#storageevent)
     10        says that StorageEvent.key is not a nullable type, and thus
     11        document.createEvent('StorageEvent').key should be '' (an empty string).
     12
     13        * storage/domstorage/events/basic-body-attribute-expected.txt: Updated the test result as described above.
     14        * storage/domstorage/events/basic-expected.txt: Ditto.
     15        * storage/domstorage/events/basic-setattribute-expected.txt: Ditto.
     16        * storage/domstorage/events/script-tests/basic-body-attribute.js: Ditto.
     17        (step6):
     18        * storage/domstorage/events/script-tests/basic-setattribute.js: Ditto.
     19        (step6):
     20        * storage/domstorage/events/script-tests/basic.js: Ditto.
     21        (step6):
     22
    1232011-11-29  Philip Rogers  <pdr@google.com>
    224
  • trunk/LayoutTests/storage/domstorage/events/basic-body-attribute-expected.txt

    r53840 r101453  
    4545storage.clear()
    4646PASS storageEventList.length is 8
    47 PASS storageEventList[7].key is null
     47PASS storageEventList[7].key is ""
    4848PASS storageEventList[7].oldValue is null
    4949PASS storageEventList[7].newValue is null
     
    9191storage.clear()
    9292PASS storageEventList.length is 8
    93 PASS storageEventList[7].key is null
     93PASS storageEventList[7].key is ""
    9494PASS storageEventList[7].oldValue is null
    9595PASS storageEventList[7].newValue is null
  • trunk/LayoutTests/storage/domstorage/events/basic-expected.txt

    r53840 r101453  
    4343storage.clear()
    4444PASS storageEventList.length is 8
    45 PASS storageEventList[7].key is null
     45PASS storageEventList[7].key is ""
    4646PASS storageEventList[7].oldValue is null
    4747PASS storageEventList[7].newValue is null
     
    8787storage.clear()
    8888PASS storageEventList.length is 8
    89 PASS storageEventList[7].key is null
     89PASS storageEventList[7].key is ""
    9090PASS storageEventList[7].oldValue is null
    9191PASS storageEventList[7].newValue is null
  • trunk/LayoutTests/storage/domstorage/events/basic-setattribute-expected.txt

    r53840 r101453  
    4545storage.clear()
    4646PASS storageEventList.length is 8
    47 PASS storageEventList[7].key is null
     47PASS storageEventList[7].key is ""
    4848PASS storageEventList[7].oldValue is null
    4949PASS storageEventList[7].newValue is null
     
    9191storage.clear()
    9292PASS storageEventList.length is 8
    93 PASS storageEventList[7].key is null
     93PASS storageEventList[7].key is ""
    9494PASS storageEventList[7].oldValue is null
    9595PASS storageEventList[7].newValue is null
  • trunk/LayoutTests/storage/domstorage/events/script-tests/basic-body-attribute.js

    r86408 r101453  
    8787{
    8888    shouldBe("storageEventList.length", "8");
    89     shouldBeNull("storageEventList[7].key");
     89    shouldBeEqualToString("storageEventList[7].key", "");
    9090    shouldBeNull("storageEventList[7].oldValue");
    9191    shouldBeNull("storageEventList[7].newValue");
  • trunk/LayoutTests/storage/domstorage/events/script-tests/basic-setattribute.js

    r86408 r101453  
    8787{
    8888    shouldBe("storageEventList.length", "8");
    89     shouldBeNull("storageEventList[7].key");
     89    shouldBeEqualToString("storageEventList[7].key", "");
    9090    shouldBeNull("storageEventList[7].oldValue");
    9191    shouldBeNull("storageEventList[7].newValue");
  • trunk/LayoutTests/storage/domstorage/events/script-tests/basic.js

    r86408 r101453  
    8787{
    8888    shouldBe("storageEventList.length", "8");
    89     shouldBeNull("storageEventList[7].key");
     89    shouldBeEqualToString("storageEventList[7].key", "");
    9090    shouldBeNull("storageEventList[7].oldValue");
    9191    shouldBeNull("storageEventList[7].newValue");
  • trunk/Source/WebCore/ChangeLog

    r101452 r101453  
     12011-11-29  Kentaro Hara  <haraken@chromium.org>
     2
     3        StorageEvent.key should not be nullable
     4        https://bugs.webkit.org/show_bug.cgi?id=73125
     5
     6        Reviewed by Adam Barth.
     7
     8        Currently, document.createEvent('StorageEvent').key is evaluated as null.
     9        However, the spec (http://www.whatwg.org/specs/web-apps/current-work/#storageevent)
     10        says that StorageEvent.key is not a nullable type, and thus
     11        document.createEvent('StorageEvent').key should be '' (an empty string).
     12
     13        * storage/StorageEvent.idl: Removed a [ConvertNullStringTo=Null] IDL from StorageEvent.key.
     14
    1152011-11-29  Philip Rogers  <pdr@google.com>
    216
  • trunk/Source/WebCore/storage/StorageEvent.idl

    r97574 r101453  
    2727
    2828    interface StorageEvent : Event {
    29         readonly attribute [ConvertNullStringTo=Null] DOMString key;
     29        readonly attribute DOMString key;
    3030        readonly attribute [ConvertNullStringTo=Null] DOMString oldValue;
    3131        readonly attribute [ConvertNullStringTo=Null] DOMString newValue;
Note: See TracChangeset for help on using the changeset viewer.