Changeset 101455 in webkit

Timestamp:

Nov 30, 2011 12:17:19 AM (12 years ago)

Author:

hayato@chromium.org

Message:

Skip writing the result of diff_image since non-chromium ports don't implement diff_image.
​https://bugs.webkit.org/show_bug.cgi?id=73381

Reviewed by Ryosuke Niwa.

This is a quick fix for the breakage of tests on non-chromium port.
We should implement diff_image later on non-chromium ports.

• Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:

(write_test_result):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/layout_tests/controllers/test_result_writer.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2011-11-29  Hayato Ito  <hayato@chromium.org>
+
+        Skip writing the result of diff_image since non-chromium ports don't implement diff_image.
+        https://bugs.webkit.org/show_bug.cgi?id=73381
+
+        Reviewed by Ryosuke Niwa.
+
+        This is a quick fix for the breakage of tests on non-chromium port.
+        We should implement diff_image later on non-chromium ports.
+
+        * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
+        (write_test_result):
+
 2011-11-29  Balazs Ankes  <Ankes.Balazs@stud.u-szeged.hu>
 

trunk/Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py

@@ -72 +72 @@
             if driver_output.image and expected_driver_output.image:
                 image_diff = port.diff_image(driver_output.image, expected_driver_output.image)[0]
-                writer.write_image_diff_files(image_diff)
+                # Non-chromium ports return 'None' since they don't implement diff_image.
+                if image_diff is not None:
+                    writer.write_image_diff_files(image_diff)
             writer.copy_file(failure.reference_filename)
         elif isinstance(failure, test_failures.FailureReftestMismatchDidNotOccur):