Changeset 101887 in webkit

Timestamp:

Dec 2, 2011 5:59:48 PM (12 years ago)

Author:

commit-queue@webkit.org

Message:

[EFL] Remove entry pointer before freeing it from matrix.
​https://bugs.webkit.org/show_bug.cgi?id=73625

Patch by JungJik Lee <​jungjik.lee@samsung.com> on 2011-12-02
Reviewed by Ryosuke Niwa.

To prevent leaving dangling pointer on the matrix, remove the entry before freeing it.

• ewk/ewk_tiled_matrix.cpp:

(ewk_tile_matrix_free):

Location:

trunk/Source/WebKit/efl

Files:

• ChangeLog (modified) (1 diff)
• ewk/ewk_tiled_matrix.cpp (modified) (1 diff)

trunk/Source/WebKit/efl/ChangeLog

@@ +1 @@
+2011-12-02  JungJik Lee  <jungjik.lee@samsung.com>
+
+        [EFL] Remove entry pointer before freeing it from matrix.
+        https://bugs.webkit.org/show_bug.cgi?id=73625
+
+        Reviewed by Ryosuke Niwa.
+
+        To prevent leaving dangling pointer on the matrix, remove the entry before freeing it.
+
+        * ewk/ewk_tiled_matrix.cpp:
+        (ewk_tile_matrix_free):
+
 2011-12-01  Ryuan Choi  <ryuan.choi@samsung.com>
 

trunk/Source/WebKit/efl/ewk/ewk_tiled_matrix.cpp

@@ -303 +303 @@
     ewk_tile_matrix_invalidate(tileMatrix);
     entry = EINA_INLIST_CONTAINER_GET(tileMatrix->matrices, Ewk_Tile_Matrix_Entry);
-    eina_matrixsparse_free(entry->matrix);    
+    tileMatrix->matrices = eina_inlist_remove(tileMatrix->matrices, (Eina_Inlist *)entry);
+    eina_matrixsparse_free(entry->matrix);
     free(entry);
     tileMatrix->matrices = 0;