Changeset 102118 in webkit

Timestamp:

Dec 6, 2011 3:24:03 AM (12 years ago)

Author:

commit-queue@webkit.org

Message:

​https://bugs.webkit.org/show_bug.cgi?id=73889
TextCheckingParagraph::offsetTo should not have a side effect.

Patch by Shinya Kawanaka <​shinyak@google.com> on 2011-12-06
Reviewed by Hajime Morita.

Since TextCheckingParagraph::offsetTo had a side effect, its cache often became inconsistent.
This is likely to cause a bug when changing SpellChecker and Editor.

No new tests. Covered by existing tests.

• editing/TextCheckingHelper.cpp:

(WebCore::TextCheckingParagraph::offsetTo):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• editing/TextCheckingHelper.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-12-06  Shinya Kawanaka  <shinyak@google.com>
+
+        https://bugs.webkit.org/show_bug.cgi?id=73889
+        TextCheckingParagraph::offsetTo should not have a side effect.
+
+        Reviewed by Hajime Morita.
+
+        Since TextCheckingParagraph::offsetTo had a side effect, its cache often became inconsistent.
+        This is likely to cause a bug when changing SpellChecker and Editor.
+
+        No new tests. Covered by existing tests.
+
+        * editing/TextCheckingHelper.cpp:
+        (WebCore::TextCheckingParagraph::offsetTo):
+
 2011-12-06  Eric Penner  <epenner@google.com>
 

trunk/Source/WebCore/editing/TextCheckingHelper.cpp

@@ -158 +158 @@
 {
     ASSERT(m_checkingRange);
-    RefPtr<Range> range = offsetAsRange();
+    RefPtr<Range> range = offsetAsRange()->cloneRange(ASSERT_NO_EXCEPTION);
     range->setEnd(position.containerNode(), position.computeOffsetInContainerNode(), ec);
     if (ec)