Changeset 102140 in webkit

Timestamp:

Dec 6, 2011 8:16:44 AM (12 years ago)

Author:

yurys@chromium.org

Message:

[Chromium] Web Inspector: getFunctionLocation should return scriptId as String not as int
​https://bugs.webkit.org/show_bug.cgi?id=73892

Reviewed by Pavel Feldman.

• bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::V8InjectedScriptHost::functionLocationCallback): scriptId should be a string not a number

• inspector/Inspector.json: removed unused parameter

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/v8/custom/V8InjectedScriptHostCustom.cpp (modified) (1 diff)
• inspector/Inspector.json (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-12-06  Yury Semikhatsky  <yurys@chromium.org>
+
+        [Chromium] Web Inspector: getFunctionLocation should return scriptId as String not as int
+        https://bugs.webkit.org/show_bug.cgi?id=73892
+
+        Reviewed by Pavel Feldman.
+
+        * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
+        (WebCore::V8InjectedScriptHost::functionLocationCallback): scriptId should be a string not a number
+        * inspector/Inspector.json: removed unused parameter
+
 2011-11-21  Balazs Kelemen  <kbalazs@webkit.org>
 

trunk/Source/WebCore/bindings/v8/custom/V8InjectedScriptHostCustom.cpp

@@ -168 +168 @@
     result->Set(v8::String::New("lineNumber"), v8::Integer::New(lineNumber));
     result->Set(v8::String::New("columnNumber"), v8::Integer::New(columnNumber));
-    result->Set(v8::String::New("scriptId"), function->GetScriptId());
+    result->Set(v8::String::New("scriptId"), function->GetScriptId()->ToString());
     return result;
 }

trunk/Source/WebCore/inspector/Inspector.json

@@ -297 +297 @@
                     { "name": "value", "type": "any", "optional": true, "description": "Remote object value (in case of primitive values or JSON values if it was requested)." },
                     { "name": "description", "type": "string", "optional": true, "description": "String representation of the object." },
-                    { "name": "objectId", "$ref": "RemoteObjectId", "optional": true, "description": "Unique object identifier (for non-primitive values)." },
-                    { "name": "functionLocation", "$ref": "Debugger.Location", "optional": true, "description": "Function location within owning script." }
+                    { "name": "objectId", "$ref": "RemoteObjectId", "optional": true, "description": "Unique object identifier (for non-primitive values)." }
                 ]
             },