Changeset 102424 in webkit

Timestamp:

Dec 8, 2011 8:19:48 PM (12 years ago)

Author:

adamk@chromium.org

Message:

[MutationObservers] V8LazyEventHandler breaks microtask delivery semantics
​https://bugs.webkit.org/show_bug.cgi?id=73492

Reviewed by Adam Barth.

Source/WebCore:

Test: fast/mutation/inline-event-listener.html

• bindings/v8/V8LazyEventListener.cpp:

(WebCore::V8LazyEventListener::prepareListenerObject): Call v8::Script::Run directly instead of going through V8Proxy.

Tools:

Add eventSender.scheduleAsynchronousKeyDown, needed to cause a
keypress event without any script on the stack.

• DumpRenderTree/chromium/EventSender.cpp:

(EventSender::EventSender):
(EventSender::keyDown):
(KeyDownTask::KeyDownTask):
(KeyDownTask::runIfValid):
(EventSender::scheduleAsynchronousKeyDown):

• DumpRenderTree/chromium/EventSender.h:

LayoutTests:

• fast/mutation/inline-event-listener-expected.txt: Added.
• fast/mutation/inline-event-listener.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/mutation/inline-event-listener-expected.txt (added)
• LayoutTests/fast/mutation/inline-event-listener.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/bindings/v8/V8LazyEventListener.cpp (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/DumpRenderTree/chromium/EventSender.cpp (modified) (3 diffs)
• Tools/DumpRenderTree/chromium/EventSender.h (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-12-08  Adam Klein  <adamk@chromium.org>
+
+        [MutationObservers] V8LazyEventHandler breaks microtask delivery semantics
+        https://bugs.webkit.org/show_bug.cgi?id=73492
+
+        Reviewed by Adam Barth.
+
+        * fast/mutation/inline-event-listener-expected.txt: Added.
+        * fast/mutation/inline-event-listener.html: Added.
+
 2011-12-08  Hayato Ito  <hayato@chromium.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-12-08  Adam Klein  <adamk@chromium.org>
+
+        [MutationObservers] V8LazyEventHandler breaks microtask delivery semantics
+        https://bugs.webkit.org/show_bug.cgi?id=73492
+
+        Reviewed by Adam Barth.
+
+        Test: fast/mutation/inline-event-listener.html
+
+        * bindings/v8/V8LazyEventListener.cpp:
+        (WebCore::V8LazyEventListener::prepareListenerObject): Call v8::Script::Run directly instead of going through V8Proxy.
+
 2011-12-08  Hayato Ito  <hayato@chromium.org>
 

trunk/Source/WebCore/bindings/v8/V8LazyEventListener.cpp

@@ -124 +124 @@
     v8::Handle<v8::Script> script = V8Proxy::compileScript(codeExternalString, m_sourceURL, m_position);
     if (!script.IsEmpty()) {
-        v8::Local<v8::Value> value = proxy->runScript(script);
+        // Call v8::Script::Run() directly to avoid an erroneous call to V8RecursionScope::didLeaveScriptContext().
+        // FIXME: Remove this code when we stop doing the 'with' hack above.
+        v8::Local<v8::Value> value = script->Run();
         if (!value.IsEmpty()) {
             ASSERT(value->IsFunction());

trunk/Tools/ChangeLog

@@ +1 @@
+2011-12-08  Adam Klein  <adamk@chromium.org>
+
+        [MutationObservers] V8LazyEventHandler breaks microtask delivery semantics
+        https://bugs.webkit.org/show_bug.cgi?id=73492
+
+        Reviewed by Adam Barth.
+
+        Add eventSender.scheduleAsynchronousKeyDown, needed to cause a
+        keypress event without any script on the stack.
+
+        * DumpRenderTree/chromium/EventSender.cpp:
+        (EventSender::EventSender):
+        (EventSender::keyDown):
+        (KeyDownTask::KeyDownTask):
+        (KeyDownTask::runIfValid):
+        (EventSender::scheduleAsynchronousKeyDown):
+        * DumpRenderTree/chromium/EventSender.h:
+
 2011-12-08  Hayato Ito  <hayato@chromium.org>
 

trunk/Tools/DumpRenderTree/chromium/EventSender.cpp

@@ -271 +271 @@
     bindMethod("releaseTouchPoint", &EventSender::releaseTouchPoint);
     bindMethod("scheduleAsynchronousClick", &EventSender::scheduleAsynchronousClick);
+    bindMethod("scheduleAsynchronousKeyDown", &EventSender::scheduleAsynchronousKeyDown);
     bindMethod("setTouchModifier", &EventSender::setTouchModifier);
     bindMethod("textZoomIn", &EventSender::textZoomIn);
@@ -501 +502 @@
 void EventSender::keyDown(const CppArgumentList& arguments, CppVariant* result)
 {
-    result->setNull();
+    if (result)
+        result->setNull();
     if (arguments.size() < 1 || !arguments[0].isString())
         return;
@@ -848 +850 @@
 }
 
+class KeyDownTask : public MethodTask<EventSender> {
+public:
+    KeyDownTask(EventSender* obj, const CppArgumentList& arg)
+        : MethodTask<EventSender>(obj), m_arguments(arg) { }
+    virtual void runIfValid() { m_object->keyDown(m_arguments, 0); }
+
+private:
+    CppArgumentList m_arguments;
+};
+
+void EventSender::scheduleAsynchronousKeyDown(const CppArgumentList& arguments, CppVariant* result)
+{
+    result->setNull();
+    postTask(new KeyDownTask(this, arguments));
+}
+
 void EventSender::beginDragWithFiles(const CppArgumentList& arguments, CppVariant* result)
 {

trunk/Tools/DumpRenderTree/chromium/EventSender.h

@@ -83 +83 @@
     void continuousMouseScrollBy(const CppArgumentList&, CppVariant*);
     void scheduleAsynchronousClick(const CppArgumentList&, CppVariant*);
+    void scheduleAsynchronousKeyDown(const CppArgumentList&, CppVariant*);
     void beginDragWithFiles(const CppArgumentList&, CppVariant*);
     CppVariant dragMode;