Changeset 102479 in webkit

Timestamp:

Dec 9, 2011 3:23:23 PM (12 years ago)

Author:

tony@chromium.org

Message:

REGRESSION(102234): 2-3% layout regression
​https://bugs.webkit.org/show_bug.cgi?id=74141

Reviewed by David Hyatt.

Don't allocate a RuleSet when there are no regions.

• css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::initForRegionStyling):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• css/CSSStyleSelector.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-12-09  Tony Chang  <tony@chromium.org>
+
+        REGRESSION(102234): 2-3% layout regression
+        https://bugs.webkit.org/show_bug.cgi?id=74141
+
+        Reviewed by David Hyatt.
+
+        Don't allocate a RuleSet when there are no regions.
+
+        * css/CSSStyleSelector.cpp:
+        (WebCore::CSSStyleSelector::initForRegionStyling):
+
 2011-12-09  Anders Carlsson  <andersca@apple.com>
 

trunk/Source/WebCore/css/CSSStyleSelector.cpp

@@ -860 +860 @@
 {
     setRegionForStyling(region);
+
+    if (!region)
+        return;
+
     // Mark that the set of rules comes from region styling since we need to filter
     // the properties that can be applied.
     m_regionRules = adoptPtr(new RuleSet(true));
-
-    if (!region)
-        return;
 
     // From all the region style rules, select those that apply to the specified region.