Changeset 102598 in webkit

Timestamp:

Dec 12, 2011 10:17:40 AM (12 years ago)

Author:

kubo@profusion.mobi

Message:

[EFL] Add API to control whether SSL certificates should be checked.
​https://bugs.webkit.org/show_bug.cgi?id=74299

Reviewed by Martin Robinson.

• ewk/ewk_main.cpp:

(_ewk_init_body): Explicitly disable certificate checks by default.

• ewk/ewk_network.cpp:

(ewk_network_tls_certificate_check_get):
(ewk_network_tls_certificate_check_set):

• ewk/ewk_network.h:

Location:

trunk/Source/WebKit/efl

Files:

• ChangeLog (modified) (1 diff, 1 prop)
• ewk/ewk_main.cpp (modified) (2 diffs)
• ewk/ewk_network.cpp (modified) (1 diff)
• ewk/ewk_network.h (modified) (2 diffs)

trunk/Source/WebKit/efl/ChangeLog

@@ +1 @@
+2011-12-12  Raphael Kubo da Costa  <kubo@profusion.mobi>
+
+        [EFL] Add API to control whether SSL certificates should be checked.
+        https://bugs.webkit.org/show_bug.cgi?id=74299
+
+        Reviewed by Martin Robinson.
+
+        * ewk/ewk_main.cpp:
+        (_ewk_init_body): Explicitly disable certificate checks by default.
+        * ewk/ewk_network.cpp:
+        (ewk_network_tls_certificate_check_get):
+        (ewk_network_tls_certificate_check_set):
+        * ewk/ewk_network.h:
+
 2011-12-07  Ryuan Choi  <ryuan.choi@samsung.com>
 

trunk/Source/WebKit/efl/ewk/ewk_main.cpp

@@ -29 +29 @@
 #include "Settings.h"
 #include "ewk_logging.h"
+#include "ewk_network.h"
 #include "ewk_private.h"
 #include "ewk_settings.h"
@@ -186 +187 @@
     }
 
+    ewk_network_tls_certificate_check_set(false);
+
     // TODO: this should move to WebCore, already reported to webkit-gtk folks:
 #if USE(SOUP)

trunk/Source/WebKit/efl/ewk/ewk_network.cpp

@@ -76 +76 @@
 }
 
+Eina_Bool ewk_network_tls_certificate_check_get()
+{
+    bool checkCertificates = false;
+
+#if USE(SOUP)
+    SoupSession* defaultSession = WebCore::ResourceHandle::defaultSession();
+    g_object_get(defaultSession, "ssl-strict", &checkCertificates, NULL);
+#endif
+
+    return checkCertificates;
+}
+
+void ewk_network_tls_certificate_check_set(Eina_Bool checkCertificates)
+{
+#if USE(SOUP)
+    SoupSession* defaultSession = WebCore::ResourceHandle::defaultSession();
+    g_object_set(defaultSession, "ssl-strict", checkCertificates, NULL);
+#endif
+}
+
 SoupSession* ewk_network_default_soup_session_get()
 {

trunk/Source/WebKit/efl/ewk/ewk_network.h

@@ -32 +32 @@
 #endif
 
+typedef struct _SoupSession SoupSession;
+
 /**
  * Sets the given proxy URI to network backend.
@@ -55 +57 @@
 EAPI void             ewk_network_state_notifier_online_set(Eina_Bool online);
 
-typedef struct _SoupSession SoupSession;
+/**
+ * Returns whether HTTPS connections should check the received certificate and error out if it is invalid.
+ *
+ * By default, HTTPS connections are performed regardless of the validity of the certificate provided.
+ */
+EAPI Eina_Bool        ewk_network_tls_certificate_check_get(void);
+
+/**
+ * Sets whether HTTPS connections should check the received certificate and error out if it is invalid.
+ *
+ * By default, HTTPS connections are performed regardless of the validity of the certificate provided.
+ *
+ * @param enable Whether to check the provided certificates or not.
+ */
+EAPI void             ewk_network_tls_certificate_check_set(Eina_Bool enable);
 
 /**