Changeset 102756 in webkit

Timestamp:

Dec 14, 2011 2:04:38 AM (12 years ago)

Author:

vsevik@chromium.org

Message:

Web Inspector: [Regression] Scripts panel debug sidebar toolbar should not be scrolled out of the screen.
​https://bugs.webkit.org/show_bug.cgi?id=74447

Reviewed by Pavel Feldman.

• inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.wasShown):

• inspector/front-end/scriptsPanel.css:

(#scripts-debug-toolbar):
(#scripts-debug-sidebar-contents):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/ScriptsPanel.js (modified) (3 diffs)
• inspector/front-end/scriptsPanel.css (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-12-13  Vsevolod Vlasov  <vsevik@chromium.org>
+
+        Web Inspector: [Regression] Scripts panel debug sidebar toolbar should not be scrolled out of the screen.
+        https://bugs.webkit.org/show_bug.cgi?id=74447
+
+        Reviewed by Pavel Feldman.
+
+        * inspector/front-end/ScriptsPanel.js:
+        (WebInspector.ScriptsPanel.prototype.wasShown):
+        * inspector/front-end/scriptsPanel.css:
+        (#scripts-debug-toolbar):
+        (#scripts-debug-sidebar-contents):
+
 2011-12-14  Alexander Færøy  <alexander.faeroy@nokia.com>
 

trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js

@@ -54 +54 @@
     this.splitView.minimalMainWidthPercent = 100 - maximalDebugSidebarWidthPercent;
 
-    this.splitView.sidebarElement.appendChild(this.debugToolbar);
+    this.sidebarElement.appendChild(this.debugToolbar);
 
     this.debugSidebarResizeWidgetElement = document.createElement("div");
@@ -104 +104 @@
         this.sidebarPanes.workers = new WebInspector.WorkersSidebarPane();
 
+    this._debugSidebarContentsElement = document.createElement("div");
+    this._debugSidebarContentsElement.id = "scripts-debug-sidebar-contents";
+    this.sidebarElement.appendChild(this._debugSidebarContentsElement);    
+
     for (var pane in this.sidebarPanes)
-        this.sidebarElement.appendChild(this.sidebarPanes[pane].element);
+        this._debugSidebarContentsElement.appendChild(this.sidebarPanes[pane].element);
 
     this.sidebarPanes.callstack.expanded = true;
@@ -202 +206 @@
         WebInspector.Panel.prototype.wasShown.call(this);
         if (Capabilities.nativeInstrumentationEnabled)
-            this.sidebarElement.insertBefore(this.sidebarPanes.domBreakpoints.element, this.sidebarPanes.xhrBreakpoints.element);
+            this._debugSidebarContentsElement.insertBefore(this.sidebarPanes.domBreakpoints.element, this.sidebarPanes.xhrBreakpoints.element);
         this.sidebarPanes.watchExpressions.show();
     },

trunk/Source/WebCore/inspector/front-end/scriptsPanel.css

@@ -51 +51 @@
     position: relative;
     margin-top: -1px;
-    height: 23px;
+    height: 24px;
+}
+
+#scripts-debug-sidebar-contents {
+    position: absolute;
+    top: 22px;
+    bottom: 0;
+    left: 0;
+    right: 0;
+    overflow: auto;
 }