Changeset 102767 in webkit

Timestamp:

Dec 14, 2011 5:00:21 AM (12 years ago)

Author:

commit-queue@webkit.org

Message:

[Non-Mac] Change event should be fired when changing option by using keyboard.
​https://bugs.webkit.org/show_bug.cgi?id=74384

Patch by Rakesh KN <​rakesh.kn@motorola.com> on 2011-12-14
Reviewed by Kent Tamura.

Source/WebCore:

Fire onchange event when option is changed using up/down/right/left/pageup/pagedown/home/end keys.

Test: fast/forms/select/menulist-onchange-fired-with-key-up-down.html

• html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::menuListDefaultEventHandler):
Setting the DispatchChangeEvent selection option flag when the option is selected using
up/down/right/left/pageup/pagedown/home/end keys.

LayoutTests:

Fire onchange event when option is changed using up/down/right/left/pageup/pagedown/home/end keys.

• fast/forms/select/menulist-onchange-fired-with-key-up-down-expected.txt: Added.
• fast/forms/select/menulist-onchange-fired-with-key-up-down.html: Added.
• platform/chromium/test_expectations.txt:

Skipped for Chromium MAC.

• platform/mac/Skipped:

Skipped for Apple MAC.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/forms/select/menulist-onchange-fired-with-key-up-down-expected.txt (added)
• LayoutTests/fast/forms/select/menulist-onchange-fired-with-key-up-down.html (added)
• LayoutTests/platform/chromium/test_expectations.txt (modified) (1 diff)
• LayoutTests/platform/mac/Skipped (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/html/HTMLSelectElement.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-12-14  Rakesh KN  <rakesh.kn@motorola.com>
+
+        [Non-Mac] Change event should be fired when changing option by using keyboard.
+        https://bugs.webkit.org/show_bug.cgi?id=74384
+
+        Reviewed by Kent Tamura.
+
+        Fire onchange event when option is changed using up/down/right/left/pageup/pagedown/home/end keys. 
+
+        * fast/forms/select/menulist-onchange-fired-with-key-up-down-expected.txt: Added.
+        * fast/forms/select/menulist-onchange-fired-with-key-up-down.html: Added.
+        * platform/chromium/test_expectations.txt:
+        Skipped for Chromium MAC.
+        * platform/mac/Skipped:
+        Skipped for Apple MAC.
+
 2011-12-14  João Paulo Rechi Vita  <jprvita@openbossa.org>
 

trunk/LayoutTests/platform/chromium/test_expectations.txt

@@ -3992 +3992 @@
 
 BUGWK74374 WIN : fast/forms/select-listbox-multiple-no-focusring.html = PASS IMAGE
+
+BUGWK74384 MAC SKIP : fast/forms/select/menulist-onchange-fired-with-key-up-down.html = FAIL

trunk/LayoutTests/platform/mac/Skipped

@@ -515 +515 @@
 # https://bugs.webkit.org/show_bug.cgi?id=73974
 fast/canvas/webgl/canvas-2d-webgl-texture.html
+
+# https://bugs.webkit.org/show_bug.cgi?id=74384
+# Skipped as this is not a expected behaviour on mac.
+fast/forms/select/menulist-onchange-fired-with-key-up-down.html

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-12-14  Rakesh KN  <rakesh.kn@motorola.com>
+
+        [Non-Mac] Change event should be fired when changing option by using keyboard.
+        https://bugs.webkit.org/show_bug.cgi?id=74384
+
+        Reviewed by Kent Tamura.
+
+        Fire onchange event when option is changed using up/down/right/left/pageup/pagedown/home/end keys.
+
+        Test: fast/forms/select/menulist-onchange-fired-with-key-up-down.html
+
+        * html/HTMLSelectElement.cpp:
+        (WebCore::HTMLSelectElement::menuListDefaultEventHandler):
+        Setting the DispatchChangeEvent selection option flag when the option is selected using
+        up/down/right/left/pageup/pagedown/home/end keys.
+
 2011-12-13  Vsevolod Vlasov  <vsevik@chromium.org>
 

trunk/Source/WebCore/html/HTMLSelectElement.cpp

@@ -1051 +1051 @@
 
         if (handled && static_cast<size_t>(listIndex) < listItems.size())
-            selectOption(listToOptionIndex(listIndex), DeselectOtherOptions | UserDriven);
+            selectOption(listToOptionIndex(listIndex), DeselectOtherOptions | DispatchChangeEvent | UserDriven);
 
         if (handled)