Changeset 102873 in webkit

Timestamp:

Dec 14, 2011 7:39:51 PM (12 years ago)

Author:

bashi@chromium.org

Message:

[Chromium] Implement PluginViewBase::getFormValue
​https://bugs.webkit.org/show_bug.cgi?id=64434

Adds getFormValue() to WebPluginContainerImpl as an implementation of PluginViewBase::getFormValue().

Reviewed by Darin Fisher.

No new tests. No behavior change at this time. We should add a test for PPAPI after chromium supports the feature.

• public/WebPlugin.h: Added getFormValue().
• src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::getFormValue): Added.

• src/WebPluginContainerImpl.h: Added getFormValue().

Location:

trunk/Source/WebKit/chromium

Files:

• ChangeLog (modified) (1 diff)
• public/WebPlugin.h (modified) (1 diff)
• src/WebPluginContainerImpl.cpp (modified) (1 diff)
• src/WebPluginContainerImpl.h (modified) (2 diffs)

trunk/Source/WebKit/chromium/ChangeLog

@@ +1 @@
+2011-12-14  Kenichi Ishibashi  <bashi@chromium.org>
+
+        [Chromium] Implement PluginViewBase::getFormValue
+        https://bugs.webkit.org/show_bug.cgi?id=64434
+
+        Adds getFormValue() to WebPluginContainerImpl as an implementation of PluginViewBase::getFormValue().
+
+        Reviewed by Darin Fisher.
+
+        No new tests. No behavior change at this time. We should add a test for PPAPI after chromium supports the feature.
+
+        * public/WebPlugin.h: Added getFormValue().
+        * src/WebPluginContainerImpl.cpp:
+        (WebKit::WebPluginContainerImpl::getFormValue): Added.
+        * src/WebPluginContainerImpl.h: Added getFormValue().
+
 2011-12-14  Sami Kyostila  <skyostil@chromium.org>
 

trunk/Source/WebKit/chromium/public/WebPlugin.h

@@ -58 +58 @@
 
     virtual NPObject* scriptableObject() = 0;
+
+    // Returns true if the form submission value is successfully obtained
+    // from the plugin. The value would be associated with the name attribute
+    // of the corresponding object element.
+    virtual bool getFormValue(WebString&) { return false; }
 
     virtual void paint(WebCanvas*, const WebRect&) = 0;

trunk/Source/WebKit/chromium/src/WebPluginContainerImpl.cpp

@@ -465 +465 @@
 }
 
+bool WebPluginContainerImpl::getFormValue(String& value)
+{
+    WebString webValue;
+    if (m_webPlugin->getFormValue(webValue)) {
+        value = webValue;
+        return true;
+    }
+    return false;
+}
+
 void WebPluginContainerImpl::willDestroyPluginLoadObserver(WebPluginLoadObserver* observer)
 {

trunk/Source/WebKit/chromium/src/WebPluginContainerImpl.h

@@ -39 +39 @@
 #include <wtf/PassRefPtr.h>
 #include <wtf/Vector.h>
+#include <wtf/text/WTFString.h>
 
 struct NPObject;
@@ -70 +71 @@
         return adoptRef(new WebPluginContainerImpl(element, webPlugin));
     }
+
+    // PluginViewBase methods
+    virtual bool getFormValue(String&);
 
     // Widget methods