Changeset 103746 in webkit


Ignore:
Timestamp:
Dec 27, 2011 6:07:26 PM (12 years ago)
Author:
dominicc@chromium.org
Message:

Remove initWebKitTransitionEvent method
​https://bugs.webkit.org/show_bug.cgi?id=71701

Reviewed by Ojan Vafai.

Source/WebCore:

Now that WebKitTransitionEvent has a constructor, we don't need
this
method. <​https://www.w3.org/Bugs/Public/show_bug.cgi?id=15339> is
tracking the change to the CSS Transitions spec.

  • dom/WebKitTransitionEvent.cpp:
  • dom/WebKitTransitionEvent.h:
  • dom/WebKitTransitionEvent.idl:

LayoutTests:

Now that WebKitTransitionEvent has a constructor, we don't need
this method.

  • fast/events/init-events-expected.txt:
  • fast/events/script-tests/init-events.js:
Location:
trunk
Files:
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r103744 r103746  
     12011-12-27  Dominic Cooney  <dominicc@chromium.org>
     2
     3        Remove initWebKitTransitionEvent method
     4        https://bugs.webkit.org/show_bug.cgi?id=71701
     5
     6        Reviewed by Ojan Vafai.
     7
     8        Now that WebKitTransitionEvent has a constructor, we don't need
     9        this method.
     10
     11        * fast/events/init-events-expected.txt:
     12        * fast/events/script-tests/init-events.js:
     13
    1142011-12-27  Ryosuke Niwa  <rniwa@webkit.org>
    215

  • trunk/LayoutTests/fast/events/init-events-expected.txt

    r100727 r103746  
    174174PASS testInitEvent('WebKitAnimation', '"a", false, false, null, 1001').animationName is 'null'
    175175PASS testInitEvent('WebKitAnimation', '"a", false, false, "b", 1001').elapsedTime is 1001
    176 PASS testInitEvent('WebKitTransition', '"a", false, false, "b", 1001').type is 'a'
    177 PASS testInitEvent('WebKitTransition', 'null, false, false, "b", 1001').type is 'null'
    178 PASS testInitEvent('WebKitTransition', '"a", false, false, "b", 1001').bubbles is false
    179 PASS testInitEvent('WebKitTransition', '"a", true, false, "b", 1001').bubbles is true
    180 PASS testInitEvent('WebKitTransition', '"a", false, false, "b", 1001').cancelable is false
    181 PASS testInitEvent('WebKitTransition', '"a", false, true, "b", 1001').cancelable is true
    182 PASS testInitEvent('WebKitTransition', '"a", false, false, "b", 1001').propertyName is 'b'
    183 PASS testInitEvent('WebKitTransition', '"a", false, false, null, 1001').propertyName is 'null'
    184 PASS testInitEvent('WebKitTransition', '"a", false, false, "b", 1001').elapsedTime is 1001
    185176PASS successfullyParsed is true
    186177

  • trunk/LayoutTests/fast/events/script-tests/init-events.js

    r100727 r103746  
    192192shouldBe("testInitEvent('WebKitAnimation', '\"a\", false, false, \"b\", 1001').elapsedTime", "1001");
    193193
    194 shouldBe("testInitEvent('WebKitTransition', '\"a\", false, false, \"b\", 1001').type", "'a'");
    195 shouldBe("testInitEvent('WebKitTransition', 'null, false, false, \"b\", 1001').type", "'null'");
    196 shouldBe("testInitEvent('WebKitTransition', '\"a\", false, false, \"b\", 1001').bubbles", "false");
    197 shouldBe("testInitEvent('WebKitTransition', '\"a\", true, false, \"b\", 1001').bubbles", "true");
    198 shouldBe("testInitEvent('WebKitTransition', '\"a\", false, false, \"b\", 1001').cancelable", "false");
    199 shouldBe("testInitEvent('WebKitTransition', '\"a\", false, true, \"b\", 1001').cancelable", "true");
    200 shouldBe("testInitEvent('WebKitTransition', '\"a\", false, false, \"b\", 1001').propertyName", "'b'");
    201 shouldBe("testInitEvent('WebKitTransition', '\"a\", false, false, null, 1001').propertyName", "'null'");
    202 shouldBe("testInitEvent('WebKitTransition', '\"a\", false, false, \"b\", 1001').elapsedTime", "1001");
    203 
    204194// WheelEvent has no init function yet; roughly speaking, we are waiting for that part of DOM 3 to stabilize.

  • trunk/Source/WebCore/ChangeLog

    r103742 r103746  
     12011-12-27  Dominic Cooney   <dominicc@chromium.org>
     2
     3        Remove initWebKitTransitionEvent method
     4        https://bugs.webkit.org/show_bug.cgi?id=71701
     5
     6        Reviewed by Ojan Vafai.
     7
     8        Now that WebKitTransitionEvent has a constructor, we don't need
     9        this
     10        method. <https://www.w3.org/Bugs/Public/show_bug.cgi?id=15339> is
     11        tracking the change to the CSS Transitions spec.
     12
     13        * dom/WebKitTransitionEvent.cpp:
     14        * dom/WebKitTransitionEvent.h:
     15        * dom/WebKitTransitionEvent.idl:
     16
    1172011-12-27  Tony Chang  <tony@chromium.org>
    218

  • trunk/Source/WebCore/dom/WebKitTransitionEvent.cpp

    r98044 r103746  
    6161}
    6262
    63 void WebKitTransitionEvent::initWebKitTransitionEvent(const AtomicString& type,
    64                                             bool canBubbleArg,
    65                                             bool cancelableArg,
    66                                             const String& propertyName,
    67                                             double elapsedTime)
    68 {
    69     if (dispatched())
    70         return;
    71 
    72     initEvent(type, canBubbleArg, cancelableArg);
    73 
    74     m_propertyName = propertyName;
    75     m_elapsedTime = elapsedTime;
    76 }
    77 
    7863const String& WebKitTransitionEvent::propertyName() const
    7964{

  • trunk/Source/WebCore/dom/WebKitTransitionEvent.h

    r98044 r103746  
    5555    virtual ~WebKitTransitionEvent();
    5656
    57     void initWebKitTransitionEvent(const AtomicString& type,
    58                                    bool canBubbleArg,
    59                                    bool cancelableArg,
    60                                    const String& propertyName,
    61                                    double elapsedTime);
    62 
    6357    const String& propertyName() const;
    6458    double elapsedTime() const;

  • trunk/Source/WebCore/dom/WebKitTransitionEvent.idl

    r100564 r103746  
    2929        ConstructorTemplate=Event
    3030    ] WebKitTransitionEvent : Event {
    31     readonly attribute [InitializedByConstructor] DOMString propertyName;
    32     readonly attribute [InitializedByConstructor] double elapsedTime;
    33 
    34     void initWebKitTransitionEvent(in [Optional=CallWithDefaultValue] DOMString typeArg,
    35                                    in [Optional=CallWithDefaultValue] boolean canBubbleArg,
    36                                    in [Optional=CallWithDefaultValue] boolean cancelableArg,
    37                                    in [Optional=CallWithDefaultValue] DOMString propertyNameArg,
    38                                    in [Optional=CallWithDefaultValue] double elapsedTimeArg);
    39 };
     31        readonly attribute [InitializedByConstructor] DOMString propertyName;
     32        readonly attribute [InitializedByConstructor] double elapsedTime;
     33    };
    4034
    4135}
Note: See TracChangeset for help on using the changeset viewer.