Changeset 104757 in webkit

Timestamp:

Jan 11, 2012 3:56:24 PM (12 years ago)

Author:

abarth@webkit.org

Message:

Source/WebCore: ​https://bugs.webkit.org/show_bug.cgi?id=75860
[Chromium Mac] no background is drawn for input elements

Patch by Avi Drissman <​avi@chromium.org> on 2012-01-09
Reviewed by Eric Seidel.

Reverts r104240 for Chromium. Unfortunately the code that uses Cocoa
API misbehaves when built with the 10.5 SDK, so we use SPI. For now.

• rendering/RenderThemeChromiumMac.h:
• rendering/RenderThemeChromiumMac.mm:

(WebCore::RenderThemeChromiumMac::paintTextField):

LayoutTests: iframe sandbox doesn't block videos from autoplaying (IETC automatic-feature-block-autoplay-video)
​https://bugs.webkit.org/show_bug.cgi?id=76111

Reviewed by Eric Seidel.

Test based on video-no-autoplay.html.

• media/no-auto-play-in-sandbox-expected.txt: Added.
• media/no-auto-play-in-sandbox.html: Added.
• media/resources/no-auto-play-in-sandbox-iframe.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/media/no-auto-play-in-sandbox-expected.txt (added)
• LayoutTests/media/no-auto-play-in-sandbox.html (added)
• LayoutTests/media/resources/no-auto-play-in-sandbox-iframe.html (added)
• Source/WebCore/ChangeLog (modified) (2 diffs)
• Source/WebCore/dom/SecurityContext.h (modified) (2 diffs)
• Source/WebCore/html/HTMLMediaElement.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-01-11  Adam Barth  <abarth@webkit.org>
+
+        iframe sandbox doesn't block videos from autoplaying (IETC automatic-feature-block-autoplay-video)
+        https://bugs.webkit.org/show_bug.cgi?id=76111
+
+        Reviewed by Eric Seidel.
+
+        Test based on video-no-autoplay.html.
+
+        * media/no-auto-play-in-sandbox-expected.txt: Added.
+        * media/no-auto-play-in-sandbox.html: Added.
+        * media/resources/no-auto-play-in-sandbox-iframe.html: Added.
+
 2012-01-11  Joshua Bell  <jsbell@chromium.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-01-09  Avi Drissman  <avi@chromium.org>
+
+        https://bugs.webkit.org/show_bug.cgi?id=75860
+        [Chromium Mac] no background is drawn for input elements
+
+        Reviewed by Eric Seidel.
+
+        Reverts r104240 for Chromium. Unfortunately the code that uses Cocoa
+        API misbehaves when built with the 10.5 SDK, so we use SPI. For now.
+
+        * rendering/RenderThemeChromiumMac.h:
+        * rendering/RenderThemeChromiumMac.mm:
+        (WebCore::RenderThemeChromiumMac::paintTextField):
+
+<<<<<<< .mine
+2012-01-11  Adam Barth  <abarth@webkit.org>
+
+        iframe sandbox doesn't block videos from autoplaying (IETC automatic-feature-block-autoplay-video)
+        https://bugs.webkit.org/show_bug.cgi?id=76111
+
+        Reviewed by Eric Seidel.
+
+        Test: media/no-auto-play-in-sandbox.html
+
+        * dom/SecurityContext.h:
+            - Add a flag for sandboxing automatic features, per the HTML5 spec.
+        * html/HTMLMediaElement.cpp:
+        (WebCore::HTMLMediaElement::setReadyState):
+            - Implement requirement in the HTML5 spec to not autoplay media
+              when automatic features are sandboxed.
+
+=======
 2012-01-11  Nate Chapin  <japhet@chromium.org>
 
@@ -41 +73 @@
         * storage/IDBObjectStoreBackendImpl.cpp:
 
+>>>>>>> .r104756
 2012-01-11  Greg Billock  <gbillock@google.com>
 

trunk/Source/WebCore/dom/SecurityContext.h

@@ -39 +39 @@
 
 enum SandboxFlag {
+    // See http://www.whatwg.org/specs/web-apps/current-work/#attr-iframe-sandbox for a list of the sandbox flags.
     SandboxNone = 0,
     SandboxNavigation = 1,
@@ -46 +47 @@
     SandboxScripts = 1 << 4,
     SandboxTopNavigation = 1 << 5,
-    SandboxPopups = 1 << 6,
+    SandboxPopups = 1 << 6, // See https://www.w3.org/Bugs/Public/show_bug.cgi?id=12393
+    SandboxAutomaticFeatures = 1 << 7,
+    // FIXME: Add http://www.whatwg.org/specs/web-apps/current-work/#sandboxed-seamless-iframes-flag when we implement seamless.
     SandboxAll = -1 // Mask with all bits set to 1.
 };

trunk/Source/WebCore/html/HTMLMediaElement.cpp

@@ -1399 +1399 @@
             scheduleEvent(eventNames().playingEvent);
 
-        if (m_autoplaying && m_paused && autoplay()) {
+        if (m_autoplaying && m_paused && autoplay() && !document()->isSandboxed(SandboxAutomaticFeatures)) {
             m_paused = false;
             invalidateCachedTime();