Changeset 105232 in webkit

Timestamp:

Jan 17, 2012 7:19:09 PM (12 years ago)

Author:

commit-queue@webkit.org

Message:

Add a check-webkit-style exception for GDBInterface.cpp
​https://bugs.webkit.org/show_bug.cgi?id=76187

Add an exception for Source/JavaScriptCore/jit/GDBInterface.cpp so
that it does not fail the style check.

Patch by Sanjoy Das <​sanjoy@playingwithpointers.com> on 2012-01-17
Reviewed by Martin Robinson.

• Scripts/webkitpy/style/checker.py: Tell the style checker to not run

readability/naming tests on
Source/JavaScriptCore/jit/GDBInterface.cpp.

• Scripts/webkitpy/style/checker_unittest.py:

(GlobalVariablesTest.test_path_rules_specifier): Add a test for
the above exception.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/style/checker.py (modified) (1 diff)
• Scripts/webkitpy/style/checker_unittest.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2012-01-17  Sanjoy Das  <sanjoy@playingwithpointers.com>
+
+        Add a check-webkit-style exception for GDBInterface.cpp
+        https://bugs.webkit.org/show_bug.cgi?id=76187
+
+        Add an exception for Source/JavaScriptCore/jit/GDBInterface.cpp so
+        that it does not fail the style check.
+
+        Reviewed by Martin Robinson.
+
+        * Scripts/webkitpy/style/checker.py: Tell the style checker to not run
+        readability/naming tests on
+        Source/JavaScriptCore/jit/GDBInterface.cpp.
+        * Scripts/webkitpy/style/checker_unittest.py:
+        (GlobalVariablesTest.test_path_rules_specifier): Add a test for
+        the above exception.
+
 2012-01-17  Hajime Morrita  <morrita@chromium.org>
 

trunk/Tools/Scripts/webkitpy/style/checker.py

@@ -226 +226 @@
       "-build/header_guard",
       "-build/include_order"]),
+
+    ([# There is no way to avoid the symbols __jit_debug_register_code
+      # and __jit_debug_descriptor when integrating with gdb.
+      "Source/JavaScriptCore/jit/GDBInterface.cpp"],
+     ["-readability/naming"]),
 ]
 

trunk/Tools/Scripts/webkitpy/style/checker_unittest.py

@@ -262 +262 @@
         assertCheck(path, "whitespace/carriage_return")
 
+        # Test if the exception for GDBInterface.cpp is in place.
+        assertNoCheck("Source/JavaScriptCore/jit/GDBInterface.cpp",
+                      "readability/naming")
+
     def test_max_reports_per_category(self):
         """Check that _MAX_REPORTS_PER_CATEGORY is valid."""