Changeset 105426 in webkit

Timestamp:

Jan 19, 2012 10:55:20 AM (12 years ago)

Author:

mihnea@adobe.com

Message:

[CSSRegions]Add support for background-color in region styling
​https://bugs.webkit.org/show_bug.cgi?id=71488

Reviewed by David Hyatt.

Source/WebCore:

This patch enables region styling again. The region styling tests were also added back.
With the improvements from ​https://bugs.webkit.org/show_bug.cgi?id=76265, hopefully we will not see the same 3% regressions
in performance.

• rendering/RenderObject.h:

(WebCore::RenderObject::style):

LayoutTests:

Add back the region styling tests.

• platform/mac-snowleopard/Skipped:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/mac-snowleopard/Skipped (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderObject.h (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-01-19  Mihnea Ovidenie  <mihnea@adobe.com>
+
+        [CSSRegions]Add support for background-color in region styling
+        https://bugs.webkit.org/show_bug.cgi?id=71488
+
+        Reviewed by David Hyatt.
+
+        Add back the region styling tests.
+
+        * platform/mac-snowleopard/Skipped:
+
 2012-01-19  David Hyatt  <hyatt@apple.com>
 

trunk/LayoutTests/platform/mac-snowleopard/Skipped

@@ -184 +184 @@
 http/tests/media/video-load-twice.html
 
-# Regression in performance
-# https://bugs.webkit.org/show_bug.cgi?id=74141
-fast/regions/region-style-block-background-color.html
-fast/regions/region-style-block-background-color2.html
-fast/regions/region-style-image-background-color.html
-fast/regions/region-style-inline-background-color.html
-
 # HiDPI tests have lower-level platform dependencies on Mac
 fast/hidpi

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-01-19  Mihnea Ovidenie  <mihnea@adobe.com>
+
+        [CSSRegions]Add support for background-color in region styling
+        https://bugs.webkit.org/show_bug.cgi?id=71488
+
+        Reviewed by David Hyatt.
+
+        This patch enables region styling again. The region styling tests were also added back. 
+        With the improvements from https://bugs.webkit.org/show_bug.cgi?id=76265, hopefully we will not see the same 3% regressions
+        in performance.
+
+        * rendering/RenderObject.h:
+        (WebCore::RenderObject::style):
+
 2012-01-16  Jer Noble  <jer.noble@apple.com>
 

trunk/Source/WebCore/rendering/RenderObject.h

@@ -1111 +1111 @@
 inline RenderStyle* RenderObject::style() const
 {
-    return m_style.get();
+    if (!inRenderFlowThread())
+        return m_style.get();
+    return styleInRegion();
 }