Changeset 106228 in webkit

Timestamp:

Jan 30, 2012 3:32:20 AM (12 years ago)

Author:

commit-queue@webkit.org

Message:

No need to keep anonymous RenderBlock in DETAILS.
​https://bugs.webkit.org/show_bug.cgi?id=77322

Patch by Shinya Kawanaka <​shinyak@google.com> on 2012-01-30
Reviewed by Hajime Morita.

Anonymous RenderBlock of DETAILS element was not squashed when detaching them.
However, it should be removed.

No new tests. Should be covered by existing tests.

• rendering/RenderBlock.cpp:

(WebCore::canMergeContiguousAnonymousBlocks):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderBlock.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-01-30  Shinya Kawanaka  <shinyak@google.com>
+
+        No need to keep anonymous RenderBlock in DETAILS.
+        https://bugs.webkit.org/show_bug.cgi?id=77322
+
+        Reviewed by Hajime Morita.
+
+        Anonymous RenderBlock of DETAILS element was not squashed when detaching them.
+        However, it should be removed.
+
+        No new tests. Should be covered by existing tests.
+
+        * rendering/RenderBlock.cpp:
+        (WebCore::canMergeContiguousAnonymousBlocks):
+
 2012-01-30  Zoltan Herczeg  <zherczeg@webkit.org>
 

trunk/Source/WebCore/rendering/RenderBlock.cpp

@@ -1000 +1000 @@
     if (oldChild->documentBeingDestroyed() || oldChild->isInline() || oldChild->virtualContinuation())
         return false;
-
-#if ENABLE(DETAILS)
-    if (oldChild->parent() && oldChild->parent()->isDetails())
-        return false;
-#endif
 
     if ((prev && (!prev->isAnonymousBlock() || toRenderBlock(prev)->continuation() || toRenderBlock(prev)->beingDestroyed()))