Changeset 106359 in webkit

Timestamp:

Jan 31, 2012 7:09:33 AM (12 years ago)

Author:

Adam Roben

Message:

Only call -typingAttributes on WebViews, not WebHTMLViews

Looks like this case was just missed in r105908.

Fixes <​http://webkit.org/b/77432> REGRESSION (r105908): WebKit1.InspectorBarTest is crashing

Reviewed by Antti Koivisto.

• TestWebKitAPI/Tests/mac/InspectorBar.mm:

(TestWebKitAPI::TEST): Call -typingAttributes on the WebView, just like we do 2 lines
earlier.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• TestWebKitAPI/Tests/mac/InspectorBar.mm (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2012-01-31  Adam Roben  <aroben@apple.com>
+
+        Only call -typingAttributes on WebViews, not WebHTMLViews
+
+        Looks like this case was just missed in r105908.
+
+        Fixes <http://webkit.org/b/77432> REGRESSION (r105908): WebKit1.InspectorBarTest is crashing
+
+        Reviewed by Antti Koivisto.
+
+        * TestWebKitAPI/Tests/mac/InspectorBar.mm:
+        (TestWebKitAPI::TEST): Call -typingAttributes on the WebView, just like we do 2 lines
+        earlier.
+
 2012-01-31  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
 

trunk/Tools/TestWebKitAPI/Tests/mac/InspectorBar.mm

@@ -67 +67 @@
     NSDictionary *attributes = [(id)webView.get() typingAttributes];
     [(id)[[[webView.get() mainFrame] frameView] documentView] doCommandBySelector:@selector(bold:)];
-    EXPECT_FALSE([attributes isEqual:[(id)[[[webView.get() mainFrame] frameView] documentView] typingAttributes]]);
+    EXPECT_FALSE([attributes isEqual:[(id)webView.get() typingAttributes]]);
     
     [webView.get() selectAll:nil];