Changeset 106459 in webkit
- Timestamp:
- Feb 1, 2012 2:31:15 AM (12 years ago)
- Location:
- trunk
- Files:
-
- 6 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r106458 r106459 1 2012-02-01 Shawn Singh <shawnsingh@chromium.org> 2 3 Fix the semantics of passing contentsVisible flag to GraphicsLayers 4 https://bugs.webkit.org/show_bug.cgi?id=76975 5 6 Reviewed by Simon Fraser. 7 8 * compositing/visibility/layer-visible-content-expected.txt: rebaselined expected result 9 * compositing/visibility/layer-visible-content.html: fixed height so that result is platform-independent 10 * platform/chromium/test_expectations.txt: removed fail expectation, it should pass now. 11 1 12 2012-02-01 Philippe Normand <pnormand@igalia.com> 2 13 -
trunk/LayoutTests/compositing/visibility/layer-visible-content-expected.txt
r105920 r106459 4 4 (GraphicsLayer 5 5 (bounds 800.00 600.00) 6 (children 16 (children 2 7 7 (GraphicsLayer 8 8 (bounds 200.00 200.00) 9 9 (drawsContent 1) 10 (contentsVisible 0)11 10 (children 1 12 11 (GraphicsLayer … … 20 19 ) 21 20 ) 21 (GraphicsLayer 22 (bounds 800.00 16.00) 23 (opacity 0.00) 24 (drawsContent 1) 25 ) 22 26 ) 23 27 ) -
trunk/LayoutTests/compositing/visibility/layer-visible-content.html
r105471 r106459 38 38 pre { 39 39 opacity: 0; /* hide in pixel result */ 40 height: 16px; /* avoid platform-dependent height difference of hidden text layer-tree */ 40 41 } 41 42 </style> -
trunk/LayoutTests/platform/chromium/test_expectations.txt
r106455 r106459 4015 4015 BUGWK76572 : http/tests/download = FAIL 4016 4016 4017 BUGWK76716 : compositing/visibility/layer-visible-content.html = IMAGE+TEXT4018 4019 4017 BUGWK76967 : media/media-fragments/TC0030-TC0039.html = PASS TIMEOUT 4020 4018 -
trunk/Source/WebCore/ChangeLog
r106456 r106459 1 2012-02-01 Shawn Singh <shawnsingh@chromium.org> 2 3 Fix the semantics of passing contentsVisible flag to GraphicsLayers 4 https://bugs.webkit.org/show_bug.cgi?id=76975 5 6 Reviewed by Simon Fraser. 7 8 This patch is covered by existing tests, in particular 9 compositing/visibility/layer-visible-content.html; its 10 expectations are rebaselined. 11 12 * rendering/RenderLayerBacking.cpp: 13 (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): 14 1 15 2012-02-01 Philippe Normand <pnormand@igalia.com> 2 16 -
trunk/Source/WebCore/rendering/RenderLayerBacking.cpp
r105920 r106459 404 404 405 405 m_owningLayer->updateVisibilityStatus(); 406 m_graphicsLayer->setContentsVisible(m_owningLayer->hasVisibleContent()); 407 406 407 // m_graphicsLayer is the corresponding GraphicsLayer for this RenderLayer and its non-compositing 408 // descendants. So, the visibility flag for m_graphicsLayer should be true if there are any 409 // non-compositing visible layers. 410 m_graphicsLayer->setContentsVisible(m_owningLayer->hasVisibleContent() || hasVisibleNonCompositingDescendantLayers()); 411 408 412 RenderStyle* style = renderer()->style(); 409 413 m_graphicsLayer->setPreserves3D(style->transformStyle3D() == TransformStyle3DPreserve3D && !renderer()->hasReflection());
Note: See TracChangeset
for help on using the changeset viewer.