Changeset 106538 in webkit

Timestamp:

Feb 2, 2012 12:09:07 AM (12 years ago)

Author:

commit-queue@webkit.org

Message:

hidden attribute on <input type=file /> suppresses the file selection dialog
​https://bugs.webkit.org/show_bug.cgi?id=58208

Patch by Rakesh KN <​rakesh.kn@motorola.com> on 2012-02-02
Reviewed by Ryosuke Niwa.

.:

• ManualTests/input-file-hidden-open-dialog-on-click.html: Added.

Adding manual test as the file dialog opens only in User gesture.

Source/WebCore:

We want to allow opening file dialog on hidden element when click() is called
on the element. The behaviour is similar to Firefox and IE.

Added manual test as the file dialog opens only on user gesture.

• html/FileInputType.cpp:

(WebCore::FileInputType::handleDOMActivateEvent):
Removed renderer check as input can be hidden.

Location:

trunk

Files:

• ChangeLog (modified) (1 diff)
• ManualTests/input-file-hidden-open-dialog-on-click.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/html/FileInputType.cpp (modified) (1 diff)

trunk/ChangeLog

@@ +1 @@
+2012-02-02  Rakesh KN  <rakesh.kn@motorola.com>
+
+        hidden attribute on <input type=file /> suppresses the file selection dialog
+        https://bugs.webkit.org/show_bug.cgi?id=58208
+
+        Reviewed by Ryosuke Niwa.
+
+        * ManualTests/input-file-hidden-open-dialog-on-click.html: Added.
+        Adding manual test as the file dialog opens only in User gesture.
+
 2012-02-01  Philippe Normand  <pnormand@igalia.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-02-02  Rakesh KN  <rakesh.kn@motorola.com>
+
+        hidden attribute on <input type=file /> suppresses the file selection dialog
+        https://bugs.webkit.org/show_bug.cgi?id=58208
+
+        Reviewed by Ryosuke Niwa.
+
+        We want to allow opening file dialog on hidden element when click() is called
+        on the element. The behaviour is similar to Firefox and IE.
+
+        Added manual test as the file dialog opens only on user gesture.
+
+        * html/FileInputType.cpp:
+        (WebCore::FileInputType::handleDOMActivateEvent):
+        Removed renderer check as input can be hidden.
+
 2012-02-01  Philippe Normand  <pnormand@igalia.com>
 

trunk/Source/WebCore/html/FileInputType.cpp

@@ -140 +140 @@
 void FileInputType::handleDOMActivateEvent(Event* event)
 {
-    if (element()->disabled() || !element()->renderer())
+    if (element()->disabled())
         return;