Changeset 106616 in webkit

Timestamp:

Feb 2, 2012 7:03:16 PM (12 years ago)

Author:

eric@webkit.org

Message:

Run tests in serial on SnowLeopard to avoid CFURLCache crashes
​https://bugs.webkit.org/show_bug.cgi?id=75145

Reviewed by Dirk Pranke.

• Scripts/webkitpy/layout_tests/port/mac.py:

(MacPort.default_child_processes):

• Scripts/webkitpy/layout_tests/port/mac_unittest.py:

(test_operating_system):
(test_default_child_processes):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/layout_tests/port/mac.py (modified) (1 diff)
• Scripts/webkitpy/layout_tests/port/mac_unittest.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2012-02-02  Eric Seidel  <eric@webkit.org>
+
+        Run tests in serial on SnowLeopard to avoid CFURLCache crashes
+        https://bugs.webkit.org/show_bug.cgi?id=75145
+
+        Reviewed by Dirk Pranke.
+
+        * Scripts/webkitpy/layout_tests/port/mac.py:
+        (MacPort.default_child_processes):
+        * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
+        (test_operating_system):
+        (test_default_child_processes):
+
 2012-02-02  Dirk Pranke  <dpranke@chromium.org>
 

trunk/Tools/Scripts/webkitpy/layout_tests/port/mac.py

@@ -88 +88 @@
         return re.search(r'ReportCrash', process_name)
 
+    def default_child_processes(self):
+        if self.is_snowleopard():
+            _log.warn("Cannot run tests in parallel on Snow Leopard due to rdar://problem/10621525.")
+            return 1
+        return super(MacPort, self).default_child_processes()
+
     def _build_java_test_support(self):
         java_tests_path = self._filesystem.join(self.layout_tests_dir(), "java")

trunk/Tools/Scripts/webkitpy/layout_tests/port/mac_unittest.py

@@ -167 +167 @@
     def test_operating_system(self):
         self.assertEqual('mac', self.make_port().operating_system())
+
+    def test_default_child_processes(self):
+        port = self.make_port(port_name='mac-lion')
+        # MockPlatformInfo only has 2 mock cores.  The important part is that 2 > 1.
+        self.assertEqual(port.default_child_processes(), 2)
+
+        # SnowLeopard has a CFNetwork bug which causes crashes if we execute more than one copy of DRT at once.
+        port = self.make_port(port_name='mac-snowleopard')
+        expected_logs = "Cannot run tests in parallel on Snow Leopard due to rdar://problem/10621525.\n"
+        child_processes = OutputCapture().assert_outputs(self, port.default_child_processes, (), expected_logs=expected_logs)
+        self.assertEqual(child_processes, 1)