Changeset 106685 in webkit

Timestamp:

Feb 3, 2012 12:57:08 PM (12 years ago)

Author:

kling@webkit.org

Message:

HTMLElement: Clean up tabindex attribute parsing.
<​http://webkit.org/b/77763>

Reviewed by Antti Koivisto.

Remove an unnecessary getAttribute() call when parsing tabindexAttr.

• html/HTMLElement.cpp:

(WebCore::HTMLElement::parseMappedAttribute):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/HTMLElement.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-02-03  Andreas Kling  <awesomekling@apple.com>
+
+        HTMLElement: Clean up tabindex attribute parsing.
+        <http://webkit.org/b/77763>
+
+        Reviewed by Antti Koivisto.
+
+        Remove an unnecessary getAttribute() call when parsing tabindexAttr.
+
+        * html/HTMLElement.cpp:
+        (WebCore::HTMLElement::parseMappedAttribute):
+
 2012-02-03  Anders Carlsson  <andersca@apple.com>
 

trunk/Source/WebCore/html/HTMLElement.cpp

@@ -190 +190 @@
         return StyledElement::parseMappedAttribute(attr);
 
-    String indexstring;
     if (attr->name() == alignAttr) {
         if (equalIgnoringCase(attr->value(), "middle"))
@@ -201 +200 @@
         addCSSProperty(attr, CSSPropertyDisplay, CSSValueNone);
     } else if (attr->name() == tabindexAttr) {
-        indexstring = getAttribute(tabindexAttr);
         int tabindex = 0;
-        if (!indexstring.length()) {
+        if (attr->isEmpty())
             clearTabIndexExplicitly();
-        } else if (parseHTMLInteger(indexstring, tabindex)) {
+        else if (parseHTMLInteger(attr->value(), tabindex)) {
             // Clamp tabindex to the range of 'short' to match Firefox's behavior.
             setTabIndexExplicitly(max(static_cast<int>(std::numeric_limits<short>::min()), min(tabindex, static_cast<int>(std::numeric_limits<short>::max()))));