Changeset 106814 in webkit

Timestamp:

Feb 6, 2012 9:33:55 AM (12 years ago)

Author:

Philippe Normand

Message:

[webkitpy] cpp style-checker complains about readability/naming in GStreamer elements source files
​https://bugs.webkit.org/show_bug.cgi?id=77866

Reviewed by Martin Robinson.

• Scripts/webkitpy/style/checker.py: Ignore readability/naming

errors in some gstreamer source code files defining new GStreamer elements.

• Scripts/webkitpy/style/checker_unittest.py:

(GlobalVariablesTest.test_path_rules_specifier):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/style/checker.py (modified) (1 diff)
• Scripts/webkitpy/style/checker_unittest.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2012-02-06  Philippe Normand  <pnormand@igalia.com>
+
+        [webkitpy] cpp style-checker complains about readability/naming in GStreamer elements source files
+        https://bugs.webkit.org/show_bug.cgi?id=77866
+
+        Reviewed by Martin Robinson.
+
+        * Scripts/webkitpy/style/checker.py: Ignore readability/naming
+        errors in some gstreamer source code files defining new GStreamer elements.
+        * Scripts/webkitpy/style/checker_unittest.py:
+        (GlobalVariablesTest.test_path_rules_specifier):
+
 2012-02-06  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Tools/Scripts/webkitpy/style/checker.py

@@ -207 +207 @@
       "-readability/parameter_name",
       "-whitespace/declaration"]),
+    ([# These files define GObjects, which implies some definitions of
+      # variables and functions containing underscores.
+      "Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer1.cpp",
+      "Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp",
+      "Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp",
+      "Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp"],
+     ["-readability/naming"]),
 
     # For third-party Python code, keep only the following checks--

trunk/Tools/Scripts/webkitpy/style/checker_unittest.py

@@ -254 +254 @@
                       "build/header_guard")
 
+        assertNoCheck("Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp",
+                      "readability/naming")
+
         # Third-party Python code: webkitpy/thirdparty
         path = "Tools/Scripts/webkitpy/thirdparty/mock.py"