Changeset 106919 in webkit

Timestamp:

Feb 7, 2012 3:19:23 AM (12 years ago)

Author:

commit-queue@webkit.org

Message:

[Qt] Prevent early test termination with newer Qt 5
​https://bugs.webkit.org/show_bug.cgi?id=77945

Patch by Simon Hausmann <​simon.hausmann@nokia.com> on 2012-02-07
Reviewed by Csaba Osztrogonác.

QTBUG-24120 tracks a regression in Qt that would make layout tests
terminate early. This patch works around it in a Qt 4 + 5 safe manner
by disabling the quitOnLastWindowClosed feature, which we don't want/need
for DRT anyway.

• DumpRenderTree/qt/main.cpp:

(main): Don't quit on last window closed.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• DumpRenderTree/qt/main.cpp (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2012-02-07  Simon Hausmann  <simon.hausmann@nokia.com>
+
+        [Qt] Prevent early test termination with newer Qt 5
+        https://bugs.webkit.org/show_bug.cgi?id=77945
+
+        Reviewed by Csaba Osztrogonác.
+
+        QTBUG-24120 tracks a regression in Qt that would make layout tests
+        terminate early. This patch works around it in a Qt 4 + 5 safe manner
+        by disabling the quitOnLastWindowClosed feature, which we don't want/need
+        for DRT anyway.
+
+        * DumpRenderTree/qt/main.cpp:
+        (main): Don't quit on last window closed.
+
 2012-02-06  Martin Robinson  <mrobinson@igalia.com>
 

trunk/Tools/DumpRenderTree/qt/main.cpp

@@ -150 +150 @@
 
     QApplication app(argc, argv);
+    app.setQuitOnLastWindowClosed(false);
 
 #if QT_VERSION <= QT_VERSION_CHECK(5, 0, 0) // FIXME: need a way to port this to Qt5.