Changeset 107005 in webkit

Timestamp:

Feb 7, 2012 4:14:42 PM (12 years ago)

Author:

leviw@chromium.org

Message:

[SVG] Use element disappears after scripted change
​https://bugs.webkit.org/show_bug.cgi?id=74392

Reviewed by Eric Seidel.

Source/WebCore:

Solution uncovered by Nikolas Zimmermann. Removing an early return that caused
SVGUseElements to not update the shadow root's style, and therefor not render
correctly.

Test: svg/custom/use-disappears-after-style-update.svg

• svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::didRecalcStyle):

LayoutTests:

• platform/mac-snowleopard/svg/custom/use-disappears-after-style-update-expected.png: Added.
• platform/mac-snowleopard/svg/custom/use-disappears-after-style-update-expected.txt: Added.
• svg/custom/use-disappears-after-style-update.svg: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/mac-snowleopard/svg/custom/use-disappears-after-style-update-expected.png (added)
• LayoutTests/platform/mac-snowleopard/svg/custom/use-disappears-after-style-update-expected.txt (added)
• LayoutTests/svg/custom/use-disappears-after-style-update.svg (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/svg/SVGUseElement.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-02-07  Levi Weintraub  <leviw@chromium.org>
+
+        [SVG] Use element disappears after scripted change
+        https://bugs.webkit.org/show_bug.cgi?id=74392
+
+        Reviewed by Eric Seidel.
+
+        * platform/mac-snowleopard/svg/custom/use-disappears-after-style-update-expected.png: Added.
+        * platform/mac-snowleopard/svg/custom/use-disappears-after-style-update-expected.txt: Added.
+        * svg/custom/use-disappears-after-style-update.svg: Added.
+
 2012-02-07  Levi Weintraub  <leviw@chromium.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-02-07  Levi Weintraub  <leviw@chromium.org>
+
+        [SVG] Use element disappears after scripted change
+        https://bugs.webkit.org/show_bug.cgi?id=74392
+
+        Reviewed by Eric Seidel.
+
+        Solution uncovered by Nikolas Zimmermann. Removing an early return that caused
+        SVGUseElements to not update the shadow root's style, and therefor not render
+        correctly.
+
+        Test: svg/custom/use-disappears-after-style-update.svg
+
+        * svg/SVGUseElement.cpp:
+        (WebCore::SVGUseElement::didRecalcStyle):
+
 2012-02-07  Kentaro Hara  <haraken@chromium.org>
 

trunk/Source/WebCore/svg/SVGUseElement.cpp

@@ -359 +359 @@
         return;
     
-    bool needsStyleUpdate = !m_needsShadowTreeRecreation;
     if (m_needsShadowTreeRecreation) {
         shadowRoot->markShadowTreeForRecreation();
@@ -366 +365 @@
 
     shadowRoot->updateFromElement();
-
-    if (!needsStyleUpdate)
-        return;
-
     shadowRoot->updateStyle(change);
 }