Changeset 107029 in webkit

Timestamp:

Feb 7, 2012 7:26:18 PM (12 years ago)

Author:

kling@webkit.org

Message:

REGRESSION(r106668-r106889): Chromium page cycler tests (Intl2) performance regressions.
<​http://webkit.org/b/78068>

Reviewed by Ryosuke Niwa.

Create CSS_IDENT values for attribute styles in the document's CSSValuePool.
This regressed in r106756 and I suspect it'll fix up the cycler regression.

• dom/StyledElement.cpp:

(WebCore::StyledElement::addCSSProperty):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/StyledElement.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-02-07  Andreas Kling  <awesomekling@apple.com>
+
+        REGRESSION(r106668-r106889): Chromium page cycler tests (Intl2) performance regressions.
+        <http://webkit.org/b/78068>
+
+        Reviewed by Ryosuke Niwa.
+
+        Create CSS_IDENT values for attribute styles in the document's CSSValuePool.
+        This regressed in r106756 and I suspect it'll fix up the cycler regression.
+
+        * dom/StyledElement.cpp:
+        (WebCore::StyledElement::addCSSProperty):
+
 2012-02-07  Noel Gordon  <noel.gordon@gmail.com>
 

trunk/Source/WebCore/dom/StyledElement.cpp

@@ -30 +30 @@
 #include "CSSStyleSheet.h"
 #include "CSSValueKeywords.h"
+#include "CSSValuePool.h"
 #include "Color.h"
 #include "ClassList.h"
@@ -143 +144 @@
 }
 
-void StyledElement::addCSSProperty(int id, int value)
-{
-    ensureAttributeStyle()->setProperty(id, value);
+void StyledElement::addCSSProperty(int propertyID, int identifier)
+{
+    ensureAttributeStyle()->setProperty(CSSProperty(propertyID, document()->cssValuePool()->createIdentifierValue(identifier)));
 }