Changeset 107046 in webkit

Timestamp:

Feb 8, 2012 12:13:58 AM (12 years ago)

Author:

haraken@chromium.org

Message:

Replace [CheckNodeSecurity] with [CheckAccessToNode]
​https://bugs.webkit.org/show_bug.cgi?id=77971

Reviewed by Adam Barth.

Source/WebCore:

[CheckNodeSecurity] is not implemented by code generators.
This patch replaces [CheckNodeSecurity] with [CheckAccessToNode].

Test: http/tests/security/cross-frame-access-frameelement.html

• page/DOMWindow.idl:

LayoutTests:

The added test checks if frameElement is accessible from the same or cross origin iframe.

• http/tests/security/cross-frame-access-frameelement-expected.txt: Added.
• http/tests/security/cross-frame-access-frameelement.html: Added.
• http/tests/security/resources/cross-frame-access-frameelement-from-iframe.html: Added.
• platform/chromium/http/tests/security/cross-frame-access-put-expected.txt: Updated the test result.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/http/tests/security/cross-frame-access-frameelement-expected.txt (added)
• LayoutTests/http/tests/security/cross-frame-access-frameelement.html (added)
• LayoutTests/http/tests/security/resources/cross-frame-access-frameelement-from-iframe.html (added)
• LayoutTests/platform/chromium/http/tests/security/cross-frame-access-put-expected.txt (modified) (2 diffs)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/page/DOMWindow.idl (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-02-08  Kentaro Hara  <haraken@chromium.org>
+
+        Replace [CheckNodeSecurity] with [CheckAccessToNode]
+        https://bugs.webkit.org/show_bug.cgi?id=77971
+
+        Reviewed by Adam Barth.
+
+        The added test checks if frameElement is accessible from the same or cross origin iframe.
+
+        * http/tests/security/cross-frame-access-frameelement-expected.txt: Added.
+        * http/tests/security/cross-frame-access-frameelement.html: Added.
+        * http/tests/security/resources/cross-frame-access-frameelement-from-iframe.html: Added.
+        * platform/chromium/http/tests/security/cross-frame-access-put-expected.txt: Updated the test result.
+
 2012-02-07  Robert Kroeger  <rjkroege@chromium.org>
 

trunk/LayoutTests/platform/chromium/http/tests/security/cross-frame-access-put-expected.txt

@@ +1 @@
+CONSOLE MESSAGE: Unsafe JavaScript attempt to access frame with URL http://127.0.0.1:8000/security/cross-frame-access-put.html from frame with URL http://localhost:8000/security/resources/cross-frame-iframe-for-put-test.html. Domains, protocols and ports must match.
+
 CONSOLE MESSAGE: Unsafe JavaScript attempt to access frame with URL http://localhost:8000/security/resources/cross-frame-iframe-for-put-test.html from frame with URL http://127.0.0.1:8000/security/cross-frame-access-put.html. Domains, protocols and ports must match.
 
@@ -484 +486 @@
 ALERT: PASS: window.embeds should be 'undefined' and is.
 ALERT: PASS: window.event should be 'undefined' and is.
-ALERT: PASS: window.frameElement should be '[object HTMLIFrameElement]' and is.
+CONSOLE MESSAGE: Unsafe JavaScript attempt to access frame with URL http://127.0.0.1:8000/security/cross-frame-access-put.html from frame with URL http://localhost:8000/security/resources/cross-frame-iframe-for-put-test.html. Domains, protocols and ports must match.
+
+ALERT: PASS: window.frameElement should be 'undefined' and is.
 ALERT: PASS: window.frames should be '[object DOMWindow]' and is.
 ALERT: PASS: window.history should be '[object History]' and is.

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-02-08  Kentaro Hara  <haraken@chromium.org>
+
+        Replace [CheckNodeSecurity] with [CheckAccessToNode]
+        https://bugs.webkit.org/show_bug.cgi?id=77971
+
+        Reviewed by Adam Barth.
+
+        [CheckNodeSecurity] is not implemented by code generators.
+        This patch replaces [CheckNodeSecurity] with [CheckAccessToNode].
+
+        Test: http/tests/security/cross-frame-access-frameelement.html
+
+        * page/DOMWindow.idl:
+
 2012-02-08  Kentaro Hara  <haraken@chromium.org>
 

trunk/Source/WebCore/page/DOMWindow.idl

@@ -61 +61 @@
         DOMSelection getSelection();
 
-        readonly attribute [CheckNodeSecurity] Element frameElement;
+        readonly attribute [CheckAccessToNode] Element frameElement;
 
         [DoNotCheckDomainSecurity] void focus();