Changeset 107097 in webkit

Timestamp:

Feb 8, 2012 9:15:42 AM (12 years ago)

Author:

caryclark@google.com

Message:

[Skia Mac] Make misspelling underline dots unclipped
​https://bugs.webkit.org/show_bug.cgi?id=78117
​http://code.google.com/p/chromium/issues/detail?id=113154

Reviewed by Stephen White.

No new tests. Existing layout tests cover this.

As is done on the CoreGraphics Mac platform, adjust the
underline width to remove partial dots, not including the
trailing transparent pixel column.

• platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::drawLineForTextChecking):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/skia/GraphicsContextSkia.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-02-08  Cary Clark  <caryclark@google.com>
+
+        [Skia Mac] Make misspelling underline dots unclipped
+        https://bugs.webkit.org/show_bug.cgi?id=78117
+        http://code.google.com/p/chromium/issues/detail?id=113154
+
+        Reviewed by Stephen White.
+
+        No new tests. Existing layout tests cover this.
+
+        As is done on the CoreGraphics Mac platform, adjust the
+        underline width to remove partial dots, not including the
+        trailing transparent pixel column.
+
+        * platform/graphics/skia/GraphicsContextSkia.cpp:
+        (WebCore::GraphicsContext::drawLineForTextChecking):
+
 2012-02-08  Pavel Feldman  <pfeldman@google.com>
 

trunk/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp

@@ -722 +722 @@
 #if PLATFORM(CHROMIUM) && OS(DARWIN)
     SkScalar originY = WebCoreFloatToSkScalar(pt.y());
+    // Make sure to draw only complete dots.
+    int rowPixels = misspellBitmap->width();
+    float widthMod = fmodf(width, rowPixels);
+    if (rowPixels - widthMod > 1)
+        width -= widthMod;
 #else
     // Offset it vertically by 1 so that there's some space under the text.