Changeset 107121 in webkit

Timestamp:

Feb 8, 2012 12:39:37 PM (12 years ago)

Author:

jamesr@google.com

Message:

Make WebGL context current early to check validity
​https://bugs.webkit.org/show_bug.cgi?id=78141

Patch by Antoine Labour <​piman@chromium.org> on 2012-02-08
Reviewed by James Robinson.

Covered by existing tests

• html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::create):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/canvas/WebGLRenderingContext.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-02-08  Antoine Labour  <piman@chromium.org>
+
+        Make WebGL context current early to check validity
+        https://bugs.webkit.org/show_bug.cgi?id=78141
+
+        Reviewed by James Robinson.
+
+        Covered by existing tests
+
+        * html/canvas/WebGLRenderingContext.cpp:
+        (WebCore):
+        (WebCore::WebGLRenderingContext::create):
+
 2012-02-08  Jonathan Backer  <backer@chromium.org>
 

trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp

@@ -406 +406 @@
     RefPtr<GraphicsContext3D> context(GraphicsContext3D::create(attributes, hostWindow));
 
-    if (!context) {
+    if (!context || !context->makeContextCurrent()) {
         canvas->dispatchEvent(WebGLContextEvent::create(eventNames().webglcontextcreationerrorEvent, false, true, "Could not create a WebGL context."));
         return nullptr;