Changeset 107137 in webkit


Ignore:
Timestamp:
Feb 8, 2012 3:14:46 PM (12 years ago)
Author:
haraken@chromium.org
Message:

Remove [CustomHeader] from CanvasPixelArray and rename [CustomHeader] to [JSCustomHeader]
​https://bugs.webkit.org/show_bug.cgi?id=78089

Reviewed by Adam Barth.

This patch removes [CustomHeader] from CanvasPixelArray.idl, since CanvasPixelArrayCustom.h
does not exist. (The reason why missing CanvasPixelArrayCustom.h has not caused build failure
is that [CustomHeader] has been JSC-specific and JSC has not enabled CanvasPixelArray.)
Also, this patch renames [CustomHeader] to [JSCustomHeader], since whether a given class
should have custom header or not will depend on JavaScript bindings.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):

  • dom/Node.idl:
  • html/canvas/CanvasPixelArray.idl:
Location:
trunk/Source/WebCore
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r107135 r107137  
     12012-02-08  Kentaro Hara  <haraken@chromium.org>
     2
     3        Remove [CustomHeader] from CanvasPixelArray and rename [CustomHeader] to [JSCustomHeader]
     4        https://bugs.webkit.org/show_bug.cgi?id=78089
     5
     6        Reviewed by Adam Barth.
     7
     8        This patch removes [CustomHeader] from CanvasPixelArray.idl, since CanvasPixelArrayCustom.h
     9        does not exist. (The reason why missing CanvasPixelArrayCustom.h has not caused build failure
     10        is that [CustomHeader] has been JSC-specific and JSC has not enabled CanvasPixelArray.)
     11        Also, this patch renames [CustomHeader] to [JSCustomHeader], since whether a given class
     12        should have custom header or not will depend on JavaScript bindings.
     13
     14        No tests. No change in behavior.
     15
     16        * bindings/scripts/CodeGeneratorJS.pm:
     17        (GenerateHeader):
     18        * dom/Node.idl:
     19        * html/canvas/CanvasPixelArray.idl:
     20
    1212012-02-08  Zalan Bujtas  <zbujtas@gmail.com>
    222

  • trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm

    r107051 r107137  
    750750    push(@headerContent, "    static JSC::JSObject* createPrototype(JSC::ExecState*, JSC::JSGlobalObject*);\n") unless ($dataNode->extendedAttributes->{"ExtendsDOMGlobalObject"});
    751751
    752     $headerTrailingIncludes{"${className}Custom.h"} = 1 if $dataNode->extendedAttributes->{"CustomHeader"};
    753 
    754     $implIncludes{"${className}Custom.h"} = 1 if !$dataNode->extendedAttributes->{"CustomHeader"} && ($dataNode->extendedAttributes->{"CustomPutFunction"} || $dataNode->extendedAttributes->{"CustomNamedSetter"});
     752    $headerTrailingIncludes{"${className}Custom.h"} = 1 if $dataNode->extendedAttributes->{"JSCustomHeader"};
     753
     754    $implIncludes{"${className}Custom.h"} = 1 if !$dataNode->extendedAttributes->{"JSCustomHeader"} && ($dataNode->extendedAttributes->{"CustomPutFunction"} || $dataNode->extendedAttributes->{"CustomNamedSetter"});
    755755
    756756    my $hasGetter = $numAttributes > 0

  • trunk/Source/WebCore/dom/Node.idl

    r107045 r107137  
    2222
    2323    interface [
    24         CustomHeader,
     24        JSCustomHeader,
    2525        JSCustomMarkFunction,
    2626        JSCustomPushEventHandlerScope,

  • trunk/Source/WebCore/html/canvas/CanvasPixelArray.idl

    r106798 r107137  
    3131    interface [
    3232        OmitConstructor,
    33         CustomHeader,
    3433        HasNumericIndexGetter,
    3534        CustomIndexedSetter
Note: See TracChangeset for help on using the changeset viewer.