Changeset 107156 in webkit

Timestamp:

Feb 8, 2012 4:50:45 PM (12 years ago)

Author:

abarth@webkit.org

Message:

Remove Python 2.5 support from WebKit
​https://bugs.webkit.org/show_bug.cgi?id=71593

Reviewed by Eric Seidel.

This is the last vestige of our Python 2.5 support.

• Scripts/webkitpy/tool/commands/queues_unittest.py:

(AbstractQueueTest.test_log_from_script_error_for_upload):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/tool/commands/queues_unittest.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2012-02-08  Adam Barth  <abarth@webkit.org>
+
+        Remove Python 2.5 support from WebKit
+        https://bugs.webkit.org/show_bug.cgi?id=71593
+
+        Reviewed by Eric Seidel.
+
+        This is the last vestige of our Python 2.5 support.
+
+        * Scripts/webkitpy/tool/commands/queues_unittest.py:
+        (AbstractQueueTest.test_log_from_script_error_for_upload):
+
 2012-02-08  Adam Barth  <abarth@webkit.org>
 

trunk/Tools/Scripts/webkitpy/tool/commands/queues_unittest.py

@@ -119 +119 @@
     def test_log_from_script_error_for_upload(self):
         self._assert_log_message(ScriptError("test"), "test")
-        # In python 2.5 unicode(Exception) is busted. See:
-        # http://bugs.python.org/issue2517
-        # With no good workaround, we just ignore these tests.
-        if not hasattr(Exception, "__unicode__"):
-            return
-
         unicode_tor = u"WebKit \u2661 Tor Arne Vestb\u00F8!"
         utf8_tor = unicode_tor.encode("utf-8")