Changeset 107266 in webkit
- Timestamp:
- Feb 9, 2012 11:16:03 AM (12 years ago)
- Location:
- trunk
- Files:
-
- 9 edited
- 1 copied
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r107264 r107266 1 2012-02-09 Sheriff Bot <webkit.review.bot@gmail.com> 2 3 Unreviewed, rolling out r107035. 4 http://trac.webkit.org/changeset/107035 5 https://bugs.webkit.org/show_bug.cgi?id=78253 6 7 Regressed DOMDivWalk (Requested by arv on #webkit). 8 9 * platform/chromium/test_expectations.txt: 10 1 11 2012-02-09 Julien Chaffraix <jchaffraix@webkit.org> 2 12 -
trunk/LayoutTests/platform/chromium/test_expectations.txt
r107262 r107266 590 590 BUGWK66377 : fast/dom/StyleSheet/gc-parent-stylesheet.html = TEXT 591 591 BUGWK66377 : fast/dom/StyleSheet/gc-rule-children-wrappers.html = TEXT 592 BUGWK66377 : fast/dom/StyleSheet/gc-styleheet-wrapper.xhtml = TEXT 592 593 593 594 // ----------------------------------------------------------------- -
trunk/Source/WebCore/ChangeLog
r107263 r107266 1 2012-02-09 Sheriff Bot <webkit.review.bot@gmail.com> 2 3 Unreviewed, rolling out r107035. 4 http://trac.webkit.org/changeset/107035 5 https://bugs.webkit.org/show_bug.cgi?id=78253 6 7 Regressed DOMDivWalk (Requested by arv on #webkit). 8 9 * Target.pri: 10 * UseV8.cmake: 11 * WebCore.gypi: 12 * bindings/scripts/CodeGeneratorV8.pm: 13 (GenerateNormalAttrGetter): 14 (HasCustomToV8Implementation): 15 * bindings/v8/custom/V8DOMStringMapCustom.cpp: 16 (WebCore::toV8): 17 (WebCore): 18 * bindings/v8/custom/V8DOMTokenListCustom.cpp: Copied from Source/WebCore/bindings/v8/custom/V8NamedNodeMapCustom.cpp. 19 (WebCore): 20 (WebCore::toV8): 21 * bindings/v8/custom/V8NamedNodeMapCustom.cpp: 22 (WebCore::toV8): 23 (WebCore): 24 1 25 2012-02-09 David Barton <dbarton@mathscribe.com> 2 26 -
trunk/Source/WebCore/Target.pri
r107257 r107266 159 159 bindings/v8/custom/V8InjectedScriptManager.cpp \ 160 160 bindings/v8/custom/V8InspectorFrontendHostCustom.cpp \ 161 bindings/v8/custom/V8DOMStringMapCustom.cpp 161 bindings/v8/custom/V8DOMStringMapCustom.cpp \ 162 bindings/v8/custom/V8DOMTokenListCustom.cpp 162 163 163 164 SOURCES += \ -
trunk/Source/WebCore/UseV8.cmake
r107035 r107266 82 82 bindings/v8/custom/V8DOMFormDataCustom.cpp 83 83 bindings/v8/custom/V8DOMStringMapCustom.cpp 84 bindings/v8/custom/V8DOMTokenListCustom.cpp 84 85 bindings/v8/custom/V8DOMWindowCustom.cpp 85 86 bindings/v8/custom/V8DataViewCustom.cpp -
trunk/Source/WebCore/WebCore.gypi
r107257 r107266 1816 1816 'bindings/v8/custom/V8DOMFormDataCustom.cpp', 1817 1817 'bindings/v8/custom/V8DOMStringMapCustom.cpp', 1818 'bindings/v8/custom/V8DOMTokenListCustom.cpp', 1818 1819 'bindings/v8/custom/V8DOMWindowCustom.cpp', 1819 1820 'bindings/v8/custom/V8DataViewCustom.cpp', -
trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm
r107204 r107266 4 4 # Copyright (C) 2006 Alexey Proskuryakov <ap@webkit.org> 5 5 # Copyright (C) 2006 Apple Computer, Inc. 6 # Copyright (C) 2007 -2012Google Inc.6 # Copyright (C) 2007, 2008, 2009 Google Inc. 7 7 # Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au> 8 8 # Copyright (C) Research In Motion Limited 2010. All rights reserved. … … 923 923 # garbage-collected prematurely when their lifetime is strongly tied to their owner. We accomplish this by inserting a reference to 924 924 # the newly created wrapper into an internal field of the holder object. 925 if ( $attrName ne "self" && (IsWrapperType($returnType) && ($attribute->type =~ /^readonly/ || $attribute->signature->extendedAttributes->{"Replaceable"})925 if (!IsNodeSubType($dataNode) && $attrName ne "self" && (IsWrapperType($returnType) && ($attribute->type =~ /^readonly/ || $attribute->signature->extendedAttributes->{"Replaceable"}) 926 926 && $returnType ne "EventTarget" && $returnType ne "SerializedScriptValue" && $returnType ne "DOMWindow" 927 927 && $returnType !~ /SVG/ && $returnType !~ /HTML/ && !IsDOMNodeType($returnType))) { … … 3120 3120 return 1 if $interfaceName eq "CSSStyleSheet"; 3121 3121 return 1 if $interfaceName eq "CanvasPixelArray"; 3122 return 1 if $interfaceName eq "DOMStringMap"; 3122 3123 return 1 if $interfaceName eq "DOMWindow"; 3124 return 1 if $interfaceName eq "DOMTokenList"; 3123 3125 return 1 if $interfaceName eq "Element"; 3124 3126 return 1 if $interfaceName eq "HTMLDocument"; 3125 3127 return 1 if $interfaceName eq "HTMLElement"; 3126 3128 return 1 if $interfaceName eq "Location"; 3129 return 1 if $interfaceName eq "NamedNodeMap"; 3127 3130 return 1 if $interfaceName eq "SVGDocument"; 3128 3131 return 1 if $interfaceName eq "SVGElement"; … … 3140 3143 return 0 if $interfaceName eq "StyleSheetList"; 3141 3144 return 0 if $interfaceName eq "DOMImplementation"; 3145 return 0 if $interfaceName eq "DOMStringMap"; 3146 return 0 if $interfaceName eq "DOMTokenList"; 3142 3147 return 0 if $interfaceName eq "TextTrack"; 3143 3148 -
trunk/Source/WebCore/bindings/v8/custom/V8DOMStringMapCustom.cpp
r107035 r107266 1 1 /* 2 * Copyright (C) 201 2Google Inc. All rights reserved.2 * Copyright (C) 2010 Google Inc. All rights reserved. 3 3 * 4 4 * Redistribution and use in source and binary forms, with or without … … 85 85 } 86 86 87 v8::Handle<v8::Value> toV8(DOMStringMap* impl) 88 { 89 if (!impl) 90 return v8::Null(); 91 v8::Handle<v8::Object> wrapper = V8DOMStringMap::wrap(impl); 92 // Add a hidden reference from the element to the DOMStringMap. 93 Element* element = impl->element(); 94 if (!wrapper.IsEmpty() && element) { 95 v8::Handle<v8::Value> elementValue = toV8(element); 96 if (!elementValue.IsEmpty() && elementValue->IsObject()) 97 V8DOMWrapper::setNamedHiddenReference(elementValue.As<v8::Object>(), "domStringMap", wrapper); 98 } 99 return wrapper; 100 } 101 87 102 } // namespace WebCore -
trunk/Source/WebCore/bindings/v8/custom/V8DOMTokenListCustom.cpp
r107264 r107266 1 1 /* 2 * Copyright (C) 20 07-2012Google Inc. All rights reserved.2 * Copyright (C) 2010 Google Inc. All rights reserved. 3 3 * 4 4 * Redistribution and use in source and binary forms, with or without … … 30 30 31 31 #include "config.h" 32 #include "V8 NamedNodeMap.h"32 #include "V8DOMTokenList.h" 33 33 34 #include "NamedNodeMap.h" 35 #include "V8Attr.h" 34 #include "DOMTokenList.h" 36 35 #include "V8Binding.h" 37 #include "V8 BindingState.h"36 #include "V8DOMWrapper.h" 38 37 #include "V8Element.h" 39 #include "V8Node.h"40 #include "V8Proxy.h"41 42 #include <wtf/RefPtr.h>43 38 44 39 namespace WebCore { 45 40 46 v8::Handle<v8::Value> V8NamedNodeMap::indexedPropertyGetter(uint32_t index, const v8::AccessorInfo& info)41 v8::Handle<v8::Value> toV8(DOMTokenList* impl) 47 42 { 48 INC_STATS("DOM.NamedNodeMap.IndexedPropertyGetter"); 49 NamedNodeMap* imp = V8NamedNodeMap::toNative(info.Holder()); 50 RefPtr<Node> result = imp->item(index); 51 if (!result) 52 return notHandledByInterceptor(); 53 54 return toV8(result.release()); 55 } 56 57 v8::Handle<v8::Value> V8NamedNodeMap::namedPropertyGetter(v8::Local<v8::String> name, const v8::AccessorInfo& info) 58 { 59 INC_STATS("DOM.NamedNodeMap.NamedPropertyGetter"); 60 61 if (!info.Holder()->GetRealNamedPropertyInPrototypeChain(name).IsEmpty()) 62 return notHandledByInterceptor(); 63 if (info.Holder()->HasRealNamedCallbackProperty(name)) 64 return notHandledByInterceptor(); 65 66 NamedNodeMap* imp = V8NamedNodeMap::toNative(info.Holder()); 67 RefPtr<Node> result = imp->getNamedItem(toWebCoreString(name)); 68 if (!result) 69 return notHandledByInterceptor(); 70 71 return toV8(result.release()); 43 if (!impl) 44 return v8::Null(); 45 v8::Handle<v8::Object> wrapper = V8DOMTokenList::wrap(impl); 46 // Add a hidden reference from the element to the DOMTokenList. 47 Element* element = impl->element(); 48 if (!wrapper.IsEmpty() && element) { 49 v8::Handle<v8::Value> elementValue = toV8(element); 50 if (!elementValue.IsEmpty() && elementValue->IsObject()) 51 V8DOMWrapper::setNamedHiddenReference(elementValue.As<v8::Object>(), "domTokenList", wrapper); 52 } 53 return wrapper; 72 54 } 73 55 -
trunk/Source/WebCore/bindings/v8/custom/V8NamedNodeMapCustom.cpp
r107035 r107266 1 1 /* 2 * Copyright (C) 2007-20 12Google Inc. All rights reserved.2 * Copyright (C) 2007-2009 Google Inc. All rights reserved. 3 3 * 4 4 * Redistribution and use in source and binary forms, with or without … … 72 72 } 73 73 74 v8::Handle<v8::Value> toV8(NamedNodeMap* impl) 75 { 76 if (!impl) 77 return v8::Null(); 78 v8::Handle<v8::Object> wrapper = V8NamedNodeMap::wrap(impl); 79 // Add a hidden reference from named node map to its owner node. 80 Element* element = impl->element(); 81 if (!wrapper.IsEmpty() && element) 82 V8DOMWrapper::setNamedHiddenReference(wrapper, "ownerNode", toV8(element)); 83 return wrapper; 84 } 85 74 86 } // namespace WebCore
Note: See TracChangeset
for help on using the changeset viewer.