Changeset 107364 in webkit

Timestamp:

Feb 9, 2012 10:34:52 PM (12 years ago)

Author:

wangxianzhu@chromium.org

Message:

Avoid compositing invisible fixed positioned elements
​https://bugs.webkit.org/show_bug.cgi?id=78186

Reviewed by James Robinson.

Source/WebCore:

Test: compositing/layer-creation/fixed-position-out-of-view.html

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingForPosition):

LayoutTests:

• compositing/layer-creation/fixed-position-out-of-view-expected.txt: Added.
• compositing/layer-creation/fixed-position-out-of-view.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/compositing/layer-creation/fixed-position-out-of-view-expected.txt (added)
• LayoutTests/compositing/layer-creation/fixed-position-out-of-view.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderLayerCompositor.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-02-09  Xianzhu Wang  <wangxianzhu@chromium.org>
+
+        Avoid compositing invisible fixed positioned elements
+        https://bugs.webkit.org/show_bug.cgi?id=78186
+
+        Reviewed by James Robinson.
+
+        * compositing/layer-creation/fixed-position-out-of-view-expected.txt: Added.
+        * compositing/layer-creation/fixed-position-out-of-view.html: Added.
+
 2012-02-09  James Robinson  <jamesr@chromium.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-02-09  Xianzhu Wang  <wangxianzhu@chromium.org>
+
+        Avoid compositing invisible fixed positioned elements
+        https://bugs.webkit.org/show_bug.cgi?id=78186
+
+        Reviewed by James Robinson.
+
+        Test: compositing/layer-creation/fixed-position-out-of-view.html
+
+        * rendering/RenderLayerCompositor.cpp:
+        (WebCore::RenderLayerCompositor::requiresCompositingForPosition):
+
 2012-02-09  Timothy Hatcher  <timothy@apple.com>
 

trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp

@@ -1568 +1568 @@
         return false;
 
+    // Fixed position elements that are invisible in the current view don't get their own layer.
+    FrameView* frameView = m_renderView->frameView();
+    if (frameView && !layer->absoluteBoundingBox().intersects(LayoutRect(frameView->scrollXForFixedPosition(), frameView->scrollYForFixedPosition(), frameView->layoutWidth(), frameView->layoutHeight())))
+        return false;
+
     return true;
 }