Changeset 107390 in webkit

Timestamp:

Feb 10, 2012 2:48:50 AM (12 years ago)

Author:

commit-queue@webkit.org

Message:

[Qt] GC should be parallel on Qt platform
​https://bugs.webkit.org/show_bug.cgi?id=73309

Patch by Roland Takacs <​takacs.roland@stud.u-szeged.hu> on 2012-02-10
Reviewed by Zoltan Herczeg.

These changes made the parallel gc feature available for Qt port.
The implementation of "registerGCThread" and "isMainThreadOrGCThread",
and a local static function [initializeGCThreads] is moved from
MainThreadMac.mm to the common MainThread.cpp to make them available
for other platforms.

Measurement results:
V8 speed-up: 1.025x as fast [From: 663.4ms To: 647.0ms ]
V8 Splay speed-up: 1.185x as fast [From: 138.4ms To: 116.8ms ]

Tested on Intel(R) Core(TM) i5-2320 CPU @ 3.00GHz with 4-core.

• JavaScriptCore.order:
• wtf/MainThread.cpp:

(WTF::initializeMainThread):
(WTF):
(WTF::initializeGCThreads):
(WTF::registerGCThread):
(WTF::isMainThreadOrGCThread):

• wtf/MainThread.h:

(WTF):

• wtf/Platform.h:
• wtf/mac/MainThreadMac.mm:

(WTF):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• JavaScriptCore.order (modified) (1 diff)
• wtf/MainThread.cpp (modified) (3 diffs)
• wtf/MainThread.h (modified) (1 diff)
• wtf/Platform.h (modified) (1 diff)
• wtf/mac/MainThreadMac.mm (modified) (3 diffs)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2012-02-10  Roland Takacs  <takacs.roland@stud.u-szeged.hu>
+
+        [Qt] GC should be parallel on Qt platform
+        https://bugs.webkit.org/show_bug.cgi?id=73309
+
+        Reviewed by Zoltan Herczeg.
+
+        These changes made the parallel gc feature available for Qt port.
+        The implementation of "registerGCThread" and "isMainThreadOrGCThread",
+        and a local static function [initializeGCThreads] is moved from
+        MainThreadMac.mm to the common MainThread.cpp to make them available
+        for other platforms.
+
+        Measurement results:
+        V8           speed-up:  1.025x as fast  [From: 663.4ms  To: 647.0ms ]
+        V8 Splay     speed-up:  1.185x as fast  [From: 138.4ms  To: 116.8ms ]
+
+        Tested on Intel(R) Core(TM) i5-2320 CPU @ 3.00GHz with 4-core.
+
+        * JavaScriptCore.order:
+        * wtf/MainThread.cpp:
+        (WTF::initializeMainThread):
+        (WTF):
+        (WTF::initializeGCThreads):
+        (WTF::registerGCThread):
+        (WTF::isMainThreadOrGCThread):
+        * wtf/MainThread.h:
+        (WTF):
+        * wtf/Platform.h:
+        * wtf/mac/MainThreadMac.mm:
+        (WTF):
+
 2012-02-09  Andy Wingo  <wingo@igalia.com>
 

trunk/Source/JavaScriptCore/JavaScriptCore.order

@@ -1145 +1145 @@
 __ZN3JSCL19jsStrDecimalLiteralERPKtS1_
 __ZN3WTF22cancelCallOnMainThreadEPFvPvES0_
+__ZN3WTF22isMainThreadOrGCThreadEv
 __ZNK3JSC8JSString9toBooleanEPNS_9ExecStateE
 __ZN3WTF10StringImpl4findEPFbtEj

trunk/Source/JavaScriptCore/wtf/MainThread.cpp

@@ -35 +35 @@
 #include "StdLibExtras.h"
 #include "Threading.h"
+#include <wtf/ThreadSpecific.h>
 
 #if PLATFORM(CHROMIUM)
@@ -102 +103 @@
     mainThreadFunctionQueueMutex();
     initializeMainThreadPlatform();
+    initializeGCThreads();
 }
 
@@ -250 +252 @@
 #endif
 
+#if ENABLE(PARALLEL_GC)
+static ThreadSpecific<bool>* isGCThread;
+#endif
+
+void initializeGCThreads()
+{
+#if ENABLE(PARALLEL_GC)
+    isGCThread = new ThreadSpecific<bool>();
+#endif
+}
+
+#if ENABLE(PARALLEL_GC)
+void registerGCThread()
+{
+    if (!isGCThread) {
+        // This happens if we're running in a process that doesn't care about
+        // MainThread.
+        return;
+    }
+
+    **isGCThread = true;
+}
+
+bool isMainThreadOrGCThread()
+{
+    if (isGCThread->isSet() && **isGCThread)
+        return true;
+
+    return isMainThread();
+}
+#elif PLATFORM(MAC) || PLATFORM(WINDOWS)
+// This is necessary because JavaScriptCore.exp doesn't support preprocessor macros.
+bool isMainThreadOrGCThread()
+{
+    return isMainThread();
+}
+#endif
+
 } // namespace WTF

trunk/Source/JavaScriptCore/wtf/MainThread.h

@@ -53 +53 @@
 
 WTF_EXPORT_PRIVATE bool isMainThread();
+
+void initializeGCThreads();
+
 #if ENABLE(PARALLEL_GC)
 void registerGCThread();
 WTF_EXPORT_PRIVATE bool isMainThreadOrGCThread();
-#elif PLATFORM(MAC)
-bool isMainThreadOrGCThread();
+#elif PLATFORM(MAC) || PLATFORM(WINDOWS)
+WTF_EXPORT_PRIVATE bool isMainThreadOrGCThread();
 #else
 inline bool isMainThreadOrGCThread() { return isMainThread(); }

trunk/Source/JavaScriptCore/wtf/Platform.h

@@ -1124 +1124 @@
 #endif
 
-#if !defined(ENABLE_PARALLEL_GC) && (PLATFORM(MAC) || PLATFORM(IOS)) && ENABLE(COMPARE_AND_SWAP)
+#if !defined(ENABLE_PARALLEL_GC) && (PLATFORM(MAC) || PLATFORM(IOS) || PLATFORM(QT)) && ENABLE(COMPARE_AND_SWAP)
 #define ENABLE_PARALLEL_GC 1
 #endif

trunk/Source/JavaScriptCore/wtf/mac/MainThreadMac.mm

@@ -36 +36 @@
 #import <wtf/HashSet.h>
 #import <wtf/Threading.h>
-#import <wtf/ThreadSpecific.h>
 
 @interface JSWTFMainThreadCaller : NSObject {
@@ -59 +58 @@
 static pthread_t mainThreadPthread;
 static NSThread* mainThreadNSThread;
-
-#if ENABLE(PARALLEL_GC)
-static ThreadSpecific<bool>* isGCThread;
-
-static void initializeGCThreads()
-{
-    isGCThread = new ThreadSpecific<bool>();
-}
-#else
-static void initializeGCThreads() { }
-#endif
 
 void initializeMainThreadPlatform()
@@ -146 +134 @@
 }
 
-#if ENABLE(PARALLEL_GC)
-void registerGCThread()
-{
-    if (!isGCThread) {
-        // This happens if we're running in a process that doesn't care about
-        // MainThread.
-        return;
-    }
-
-    **isGCThread = true;
-}
-
-bool isMainThreadOrGCThread()
-{
-    if (isGCThread->isSet() && **isGCThread)
-        return true;
-    
-    return isMainThread();
-}
-#else
-// This is necessary because JavaScriptCore.exp doesn't support preprocessor macros.
-bool isMainThreadOrGCThread()
-{
-    return isMainThread();
-}
-#endif
-
 } // namespace WTF