Changeset 107440 in webkit

Timestamp:

Feb 10, 2012 2:17:30 PM (12 years ago)

Author:

benjamin@webkit.org

Message:

DefaultLocalizationStrategy::htmlSelectMultipleItems() should use size_t instead of int
​https://bugs.webkit.org/show_bug.cgi?id=78374

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2012-02-10
Reviewed by Joseph Pecoraro.

The value comes from size_t and is converted to int for no good reason. We should use
size_t.

• platform/DefaultLocalizationStrategy.cpp:

(WebCore::DefaultLocalizationStrategy::htmlSelectMultipleItems):

• platform/DefaultLocalizationStrategy.h:

(DefaultLocalizationStrategy):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/DefaultLocalizationStrategy.cpp (modified) (2 diffs)
• platform/DefaultLocalizationStrategy.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-02-10  Benjamin Poulain  <bpoulain@apple.com>
+
+        DefaultLocalizationStrategy::htmlSelectMultipleItems() should use size_t instead of int
+        https://bugs.webkit.org/show_bug.cgi?id=78374
+
+        Reviewed by Joseph Pecoraro.
+
+        The value comes from size_t and is converted to int for no good reason. We should use
+        size_t.
+
+        * platform/DefaultLocalizationStrategy.cpp:
+        (WebCore::DefaultLocalizationStrategy::htmlSelectMultipleItems):
+        * platform/DefaultLocalizationStrategy.h:
+        (DefaultLocalizationStrategy):
+
 2012-02-10  Anders Carlsson  <andersca@apple.com>
 

trunk/Source/WebCore/platform/DefaultLocalizationStrategy.cpp

@@ -769 +769 @@
 
 #if PLATFORM(IOS)
-String DefaultLocalizationStrategy::htmlSelectMultipleItems(int count)
+String DefaultLocalizationStrategy::htmlSelectMultipleItems(size_t count)
 {
     switch (count) {
@@ -777 +777 @@
         return WEB_UI_STRING("1 Item", "Present the element <select multiple> when a single <option> is selected (iOS only)");
     default:
-        return formatLocalizedString(WEB_UI_STRING("%d Items", "Present the number of selected <option> items in a <select multiple> element (iOS only)"), count);
+        return formatLocalizedString(WEB_UI_STRING("%zu Items", "Present the number of selected <option> items in a <select multiple> element (iOS only)"), count);
     }
 }

trunk/Source/WebCore/platform/DefaultLocalizationStrategy.h

@@ -171 +171 @@
     virtual String keygenKeychainItemName(const String& host);
 #if PLATFORM(IOS)
-    virtual String htmlSelectMultipleItems(int);
+    virtual String htmlSelectMultipleItems(size_t);
 #endif // PLATFORM(IOS)
 #endif // PLATFORM(MAC)