Changeset 107452 in webkit

Timestamp:

Feb 10, 2012 3:53:54 PM (12 years ago)

Author:

commit-queue@webkit.org

Message:

Add keyframes to LayoutTests/media/content/test.ogv to hasten test completion & avoid timeouts.
​https://bugs.webkit.org/show_bug.cgi?id=78058

Patch by Ami Fischman <​fischman@chromium.org> on 2012-02-10
Reviewed by Eric Carlson.
File was created with ffmpeg2theora v0.24, command-line:
ffmpeg2theora --no-upscaling --no-skeleton -e 6.02 -K 21 test.mp4 -o test.ogv
The important bit was the addition of "-K 21" to force keyframe creation.
The other flags are important to minimize breakage of tests that hardcode
expectations like "the first 100k will contain the metadata" etc.

Before this, seeking to 5.6s would use the (only) keyframe at 2.4s and
have to decode all the way forward from there, which would be sometimes
timeout (presumably on overloaded bots).

• media/content/test.ogv:
• platform/chromium/test_expectations.txt:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• media/content/test.ogv (modified) (previous)
• platform/chromium/test_expectations.txt (modified) (3 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-02-10  Ami Fischman  <fischman@chromium.org>
+
+        Add keyframes to LayoutTests/media/content/test.ogv to hasten test completion & avoid timeouts.
+        https://bugs.webkit.org/show_bug.cgi?id=78058
+
+        Reviewed by Eric Carlson.
+        File was created with ffmpeg2theora v0.24, command-line:
+        ffmpeg2theora --no-upscaling --no-skeleton -e 6.02 -K 21 test.mp4 -o test.ogv
+        The important bit was the addition of "-K 21" to force keyframe creation.
+        The other flags are important to minimize breakage of tests that hardcode 
+        expectations like "the first 100k will contain the metadata" etc.
+
+        Before this, seeking to 5.6s would use the (only) keyframe at 2.4s and
+        have to decode all the way forward from there, which would be sometimes
+        timeout (presumably on overloaded bots).
+
+        * media/content/test.ogv:
+        * platform/chromium/test_expectations.txt:
+
 2012-02-10  Adam Langley  <agl@chromium.org>
 

trunk/LayoutTests/platform/chromium/test_expectations.txt

@@ -2456 +2456 @@
 BUG_DRT : http/tests/misc/slow-loading-image-in-pattern.html = IMAGE
 
-// BUGCR59415 : cannot repro the flakiness
-BUGCR59415 WIN : media/video-loop.html = PASS TIMEOUT TEXT
-
 // This test needs enhanced eventSender.contextMenu() return value.
 // See https://bugs.webkit.org/show_bug.cgi?id=45021 for more info.
@@ -2675 +2672 @@
 
 // Accelerated 2d for mac isn't supported yet, so SKIP this test for now.
-BUGCR74979 SKIP MAC GPU : media/video-canvas-alpha.html = IMAGE
+// Uncomment when rebaselining for BUGWK78367.
+// BUGCR74979 SKIP MAC GPU : media/video-canvas-alpha.html = IMAGE
 
 BUGWK55968 MAC : compositing/webgl/webgl-nonpremultiplied-blend.html = IMAGE IMAGE+TEXT
@@ -4017 +4015 @@
 // Started to fail after r107349.
 BUGWK78331 : editing/spelling/spelling-marker-description.html = TEXT
+
+// Need rebaselining.
+BUGWK78367 : media/controls-after-reload.html = IMAGE
+BUGWK78367 : media/controls-strict.html = IMAGE
+BUGWK78367 : media/controls-styling.html = IMAGE
+BUGWK78367 : media/controls-without-preload.html = IMAGE
+BUGWK78367 : media/video-aspect-ratio.html = IMAGE
+// Uncomment BUGCR74979 entry above when rebaselining removes the next expectation.
+BUGWK78367 : media/video-canvas-alpha.html = IMAGE
+BUGWK78367 : media/video-display-toggle.html = IMAGE
+BUGWK78367 : media/video-layer-crash.html = IMAGE
+BUGWK78367 : media/video-playing-and-pause.html = IMAGE
+BUGWK78367 : media/video-transformed.html = IMAGE
+BUGWK78367 : media/video-volume-slider.html = IMAGE
+BUGWK78367 : media/video-zoom-controls.html = IMAGE
+BUGWK78367 : media/video-zoom.html = IMAGE