Changeset 107522 in webkit

Timestamp:

Feb 12, 2012 7:15:50 PM (12 years ago)

Author:

commit-queue@webkit.org

Message:

Add toText and isTextNode helpers in Text class.
​https://bugs.webkit.org/show_bug.cgi?id=78140

Unit test case for the new style checker introduced.

Patch by Joe Thomas <​joethomas@motorola.com> on 2012-02-12
Reviewed by Adam Barth.

• Scripts/webkitpy/style/checkers/cpp_unittest.py:

(CppStyleTest):
(CppStyleTest.test_static_cast_readability): Added a unit test case.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/style/checkers/cpp_unittest.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2012-02-12  Joe Thomas  <joethomas@motorola.com>
+
+        Add toText and isTextNode helpers in Text class.
+        https://bugs.webkit.org/show_bug.cgi?id=78140
+
+        Unit test case for the new style checker introduced.
+
+        Reviewed by Adam Barth.
+
+        * Scripts/webkitpy/style/checkers/cpp_unittest.py:
+        (CppStyleTest):
+        (CppStyleTest.test_static_cast_readability): Added a unit test case.
+
 2012-02-12  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
 

trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py

@@ -759 +759 @@
         self.assert_language_rules_check('foo.cpp', statement, error_message)
         self.assert_language_rules_check('foo.h', statement, error_message)
+
+    # Test for static_cast readability.
+    def test_static_cast_readability(self):
+        self.assert_lint(
+            'Text* x = static_cast<Text*>(foo);',
+            'Consider using toText helper function in WebCore/dom/Text.h '
+            'instead of static_cast<Text*>'
+            '  [readability/check] [4]')
 
     # We cannot test this functionality because of difference of