Changeset 107567 in webkit
- Timestamp:
- Feb 13, 2012 6:27:51 AM (12 years ago)
- Location:
- trunk
- Files:
-
- 7 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r107564 r107567 1 2012-02-13 Peter Rybin <peter.rybin@gmail.com> 2 3 Web Inspector: In Inspector.json PropertyDescriptor.writable should be declared optional 4 https://bugs.webkit.org/show_bug.cgi?id=77917 5 6 Reviewed by Pavel Feldman. 7 8 "Undefined" getter and setter is now visible. 9 10 * inspector/runtime/runtime-getProperties-expected.txt: 11 1 12 2012-02-13 Csaba Osztrogonác <ossy@webkit.org> 2 13 -
trunk/LayoutTests/inspector/runtime/runtime-getProperties-expected.txt
r92765 r107567 37 37 writable : false 38 38 } 39 { 40 name : "set foo" 41 value : { 42 type : "undefined" 43 description : "undefined" 44 objectId : <undefined> 45 } 46 enumerable : true 47 writable : false 48 } 39 49 -
trunk/Source/WebCore/ChangeLog
r107565 r107567 1 2012-02-13 Peter Rybin <peter.rybin@gmail.com> 2 3 Web Inspector: In Inspector.json PropertyDescriptor.writable should be declared optional 4 https://bugs.webkit.org/show_bug.cgi?id=77917 5 6 Reviewed by Pavel Feldman. 7 8 Property descriptor is fixed in Inspector.json. Also retroactively in 9 0.1 and 1.0. 10 Injected script in instructed to never return null property values. 11 12 * inspector/InjectedScriptSource.js: 13 (.): 14 * inspector/Inspector-0.1.json: 15 * inspector/Inspector-1.0.json: 16 * inspector/Inspector.json: 17 1 18 2012-02-13 ChangSeok Oh <shivamidow@gmail.com> 2 19 -
trunk/Source/WebCore/inspector/InjectedScriptSource.js
r106657 r107567 185 185 for (var i = 0; i < descriptors.length; ++i) { 186 186 var descriptor = descriptors[i]; 187 if ( descriptor.get)187 if ("get" in descriptor) 188 188 descriptor.get = this._wrapObject(descriptor.get, objectGroupName); 189 if ( descriptor.set)189 if ("set" in descriptor) 190 190 descriptor.set = this._wrapObject(descriptor.set, objectGroupName); 191 191 if ("value" in descriptor) 192 192 descriptor.value = this._wrapObject(descriptor.value, objectGroupName); 193 if (!("configurable" in descriptor)) 194 descriptor.configurable = false; 195 if (!("enumerable" in descriptor)) 196 descriptor.enumerable = false; 197 193 198 } 194 199 return descriptors; -
trunk/Source/WebCore/inspector/Inspector-0.1.json
r106787 r107567 266 266 { "name": "name", "type": "string", "description": "Property name." }, 267 267 { "name": "value", "$ref": "RemoteObject", "optional": true, "description": "The value associated with the property." }, 268 { "name": "writable", "type": "boolean", " description": "True if the value associated with the property may be changed (data descriptors only)." },268 { "name": "writable", "type": "boolean", "optional": true, "description": "True if the value associated with the property may be changed (data descriptors only)." }, 269 269 { "name": "get", "$ref": "RemoteObject", "optional": true, "description": "A function which serves as a getter for the property, or <code>undefined</code> if there is no getter (accessor descriptors only)." }, 270 270 { "name": "set", "$ref": "RemoteObject", "optional": true, "description": "A function which serves as a setter for the property, or <code>undefined</code> if there is no setter (accessor descriptors only)." }, -
trunk/Source/WebCore/inspector/Inspector-1.0.json
r106787 r107567 377 377 { "name": "name", "type": "string", "description": "Property name." }, 378 378 { "name": "value", "$ref": "RemoteObject", "optional": true, "description": "The value associated with the property." }, 379 { "name": "writable", "type": "boolean", " description": "True if the value associated with the property may be changed (data descriptors only)." },379 { "name": "writable", "type": "boolean", "optional": true, "description": "True if the value associated with the property may be changed (data descriptors only)." }, 380 380 { "name": "get", "$ref": "RemoteObject", "optional": true, "description": "A function which serves as a getter for the property, or <code>undefined</code> if there is no getter (accessor descriptors only)." }, 381 381 { "name": "set", "$ref": "RemoteObject", "optional": true, "description": "A function which serves as a setter for the property, or <code>undefined</code> if there is no setter (accessor descriptors only)." }, -
trunk/Source/WebCore/inspector/Inspector.json
r107220 r107567 378 378 { "name": "name", "type": "string", "description": "Property name." }, 379 379 { "name": "value", "$ref": "RemoteObject", "optional": true, "description": "The value associated with the property." }, 380 { "name": "writable", "type": "boolean", " description": "True if the value associated with the property may be changed (data descriptors only)." },380 { "name": "writable", "type": "boolean", "optional": true, "description": "True if the value associated with the property may be changed (data descriptors only)." }, 381 381 { "name": "get", "$ref": "RemoteObject", "optional": true, "description": "A function which serves as a getter for the property, or <code>undefined</code> if there is no getter (accessor descriptors only)." }, 382 382 { "name": "set", "$ref": "RemoteObject", "optional": true, "description": "A function which serves as a setter for the property, or <code>undefined</code> if there is no setter (accessor descriptors only)." },
Note: See TracChangeset
for help on using the changeset viewer.