Changeset 107883 in webkit

Timestamp:

Feb 15, 2012 9:42:02 PM (12 years ago)

Author:

commit-queue@webkit.org

Message:

Add support for the translate attribute in html elements.
​https://bugs.webkit.org/show_bug.cgi?id=78751

Patch by Pablo Flouret <​pablof@motorola.com> on 2012-02-15
Reviewed by Adam Barth.

The translate attribute is used to specify whether an element's
attribute values and the values of its Text node children are to be
translated when the page is localized, or whether to leave them
unchanged.

Details at ​http://www.whatwg.org/specs/web-apps/current-work/multipage/elements.html#attr-translate

Source/WebCore:

Test: fast/dom/HTMLElement/translate.html

• html/HTMLAttributeNames.in:
• html/HTMLElement.cpp:

(WebCore::HTMLElement::translateAttributeMode):
(WebCore):
(WebCore::HTMLElement::translate):
(WebCore::HTMLElement::setTranslate):

• html/HTMLElement.h:

(HTMLElement):

• html/HTMLElement.idl:

LayoutTests:

• fast/dom/HTMLElement/translate-expected.txt: Added.
• fast/dom/HTMLElement/translate.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/dom/HTMLElement/translate-expected.txt (added)
• LayoutTests/fast/dom/HTMLElement/translate.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/html/HTMLAttributeNames.in (modified) (1 diff)
• Source/WebCore/html/HTMLElement.cpp (modified) (1 diff)
• Source/WebCore/html/HTMLElement.h (modified) (3 diffs)
• Source/WebCore/html/HTMLElement.idl (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-02-15  Pablo Flouret  <pablof@motorola.com>
+
+        Add support for the translate attribute in html elements.
+        https://bugs.webkit.org/show_bug.cgi?id=78751
+
+        Reviewed by Adam Barth.
+
+        The translate attribute is used to specify whether an element's
+        attribute values and the values of its Text node children are to be
+        translated when the page is localized, or whether to leave them
+        unchanged.
+
+        Details at http://www.whatwg.org/specs/web-apps/current-work/multipage/elements.html#attr-translate
+
+        * fast/dom/HTMLElement/translate-expected.txt: Added.
+        * fast/dom/HTMLElement/translate.html: Added.
+
 2012-02-15  Noel Gordon  <noel.gordon@gmail.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-02-15  Pablo Flouret  <pablof@motorola.com>
+
+        Add support for the translate attribute in html elements.
+        https://bugs.webkit.org/show_bug.cgi?id=78751
+
+        Reviewed by Adam Barth.
+
+        The translate attribute is used to specify whether an element's
+        attribute values and the values of its Text node children are to be
+        translated when the page is localized, or whether to leave them
+        unchanged.
+
+        Details at http://www.whatwg.org/specs/web-apps/current-work/multipage/elements.html#attr-translate
+
+        Test: fast/dom/HTMLElement/translate.html
+
+        * html/HTMLAttributeNames.in:
+        * html/HTMLElement.cpp:
+        (WebCore::HTMLElement::translateAttributeMode):
+        (WebCore):
+        (WebCore::HTMLElement::translate):
+        (WebCore::HTMLElement::setTranslate):
+        * html/HTMLElement.h:
+        (HTMLElement):
+        * html/HTMLElement.idl:
+
 2012-02-15  Sami Kyostila  <skyostil@google.com>
 

trunk/Source/WebCore/html/HTMLAttributeNames.in

@@ -305 +305 @@
 top
 topmargin
+translate
 truespeed
 type

trunk/Source/WebCore/html/HTMLElement.cpp

@@ -801 +801 @@
 }
 
+TranslateAttributeMode HTMLElement::translateAttributeMode() const
+{
+    const AtomicString& value = getAttribute(translateAttr);
+
+    if (value == nullAtom)
+        return TranslateAttributeInherit;
+    if (equalIgnoringCase(value, "yes") || equalIgnoringCase(value, ""))
+        return TranslateAttributeYes;
+    if (equalIgnoringCase(value, "no"))
+        return TranslateAttributeNo;
+
+    return TranslateAttributeInherit;
+}
+
+bool HTMLElement::translate() const
+{
+    for (const Node* n = this; n; n = n->parentNode()) {
+        if (n->isHTMLElement()) {
+            TranslateAttributeMode mode = static_cast<const HTMLElement*>(n)->translateAttributeMode();
+            if (mode != TranslateAttributeInherit) {
+                ASSERT(mode == TranslateAttributeYes || mode == TranslateAttributeNo);
+                return mode == TranslateAttributeYes;
+            }
+        }
+    }
+
+    // Default on the root element is translate=yes.
+    return true;
+}
+
+void HTMLElement::setTranslate(bool enable)
+{
+    setAttribute(translateAttr, enable ? "yes" : "no");
+}
+
+
 HTMLCollection* HTMLElement::children()
 {

trunk/Source/WebCore/html/HTMLElement.h

@@ -36 +36 @@
 #endif
 
+enum TranslateAttributeMode {
+    TranslateAttributeYes,
+    TranslateAttributeNo,
+    TranslateAttributeInherit
+};
+
 class HTMLElement : public StyledElement {
 public:
@@ -68 +74 @@
     bool spellcheck() const;
     void setSpellcheck(bool);
+
+    bool translate() const;
+    void setTranslate(bool);
 
     void click();
@@ -122 +131 @@
     TextDirection directionality(Node** strongDirectionalityTextNode= 0) const;
 
+    TranslateAttributeMode translateAttributeMode() const;
+
 #if ENABLE(MICRODATA)
     virtual String itemValueText() const;

trunk/Source/WebCore/html/HTMLElement.idl

@@ -31 +31 @@
                  attribute [Reflect] DOMString title;
                  attribute [Reflect] DOMString lang;
+                 attribute boolean             translate;
                  attribute [Reflect] DOMString dir;
                  attribute [Reflect=class] DOMString className;